Changeset 41018 in webkit


Ignore:
Timestamp:
Feb 15, 2009 1:39:47 PM (15 years ago)
Author:
ddkilzer@apple.com
Message:

Move duplicate caretWidth constants to RenderObject.h

Reviewed by Dan Bernstein.

No test since no change in behavior.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::localCaretRect): Removed caretWidth.
  • rendering/RenderBox.cpp: (WebCore::RenderBox::localCaretRect): Ditto.
  • rendering/RenderObject.h: Added caretWidth definition.
  • rendering/RenderText.cpp: (WebCore::RenderText::localCaretRect): Removed caretWidth.
Location:
trunk/WebCore
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r41017 r41018  
     12009-02-15  David Kilzer  <ddkilzer@apple.com>
     2
     3        Move duplicate caretWidth constants to RenderObject.h
     4
     5        Reviewed by Dan Bernstein.
     6
     7        No test since no change in behavior.
     8
     9        * rendering/RenderBlock.cpp:
     10        (WebCore::RenderBlock::localCaretRect): Removed caretWidth.
     11        * rendering/RenderBox.cpp:
     12        (WebCore::RenderBox::localCaretRect): Ditto.
     13        * rendering/RenderObject.h: Added caretWidth definition.
     14        * rendering/RenderText.cpp:
     15        (WebCore::RenderText::localCaretRect): Removed caretWidth.
     16
    1172009-02-13  Dimitri Glazkov  <dglazkov@chromium.org>
    218

  • trunk/WebCore/rendering/RenderBlock.cpp

    r40980 r41018  
    48844884    RenderStyle* currentStyle = firstLineStyle();
    48854885    int height = lineHeight(true);
    4886     const int caretWidth = 1;
    48874886
    48884887    enum CaretAlignment { alignLeft, alignRight, alignCenter };

  • trunk/WebCore/rendering/RenderBox.cpp

    r40964 r41018  
    25922592
    25932593    // FIXME: What about border and padding?
    2594     const int caretWidth = 1;
    25952594    IntRect rect(x(), y(), caretWidth, height());
    25962595    TextDirection direction = box ? box->direction() : style()->direction();

  • trunk/WebCore/rendering/RenderObject.h

    r40989 r41018  
    9797    BSRight
    9898};
     99
     100const int caretWidth = 1;
    99101
    100102#if ENABLE(DASHBOARD_SUPPORT)

  • trunk/WebCore/rendering/RenderText.cpp

    r40880 r41018  
    401401    }
    402402
    403     const int caretWidth = 1;
    404403    return IntRect(left, top, caretWidth, height);
    405404}
Note: See TracChangeset for help on using the changeset viewer.