Changeset 41333 in webkit

Timestamp:

Mar 1, 2009 8:22:15 AM (15 years ago)

Author:

kov@webkit.org

Message:

2009-03-01 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Holger Freyther.

Avoid leaking errors when reporting GIO errors.

• platform/network/soup/ResourceHandleSoup.cpp: (WebCore::readCallback): (WebCore::openCallback): (WebCore::queryInfoCallback):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/soup/ResourceHandleSoup.cpp (modified) (4 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-03-01  Gustavo Noronha Silva  <gns@gnome.org>
+
+        Reviewed by Holger Freyther.
+
+        Avoid leaking errors when reporting GIO errors.
+
+        * platform/network/soup/ResourceHandleSoup.cpp:
+        (WebCore::readCallback):
+        (WebCore::openCallback):
+        (WebCore::queryInfoCallback):
+
 2009-03-01  Gustavo Noronha Silva  <gns@gnome.org>
 

trunk/WebCore/platform/network/soup/ResourceHandleSoup.cpp

@@ -697 +697 @@
     if (error) {
         ResourceError resourceError = networkErrorForFile(d->m_gfile, error);
+        g_error_free(error);
         cleanupGioOperation(d);
         client->didFail(handle.get(), resourceError);
@@ -738 +739 @@
     if (error) {
         ResourceError resourceError = networkErrorForFile(d->m_gfile, error);
+        g_error_free(error);
         cleanupGioOperation(d);
         client->didFail(handle, resourceError);
@@ -785 +787 @@
 
         ResourceError resourceError = networkErrorForFile(d->m_gfile, error);
+        g_error_free(error);
         cleanupGioOperation(d);
         client->didFail(handle, resourceError);
@@ -794 +797 @@
         // generate a listing? How? What do other backends do here?
 
-        ResourceError resourceError = networkErrorForFile(d->m_gfile, error);
+        ResourceError resourceError = networkErrorForFile(d->m_gfile, 0);
         cleanupGioOperation(d);
         client->didFail(handle, resourceError);