Changeset 41434 in webkit


Ignore:
Timestamp:
Mar 4, 2009 2:29:54 PM (15 years ago)
Author:
levin@chromium.org
Message:

WebCore:

2009-03-04 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 24337: Assert when doing sync XHR in a worker for a cacheable response.
<https://bugs.webkit.org/show_bug.cgi?id=24337>

Tests: http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html

http/tests/xmlhttprequest/workers/xmlhttprequest-file-not-found.html

  • loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::willCacheResponse): An identifier is only asssigned if resource load callbacks are done. So don't send willCacheResponse which uses identifier if resource load callbacks aren't being sent.

LayoutTests:

2009-03-04 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 24337: Assert when doing sync XHR in a worker for a cacheable response.
<https://bugs.webkit.org/show_bug.cgi?id=24337>

  • http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html: Added.
  • http/tests/xmlhttprequest/workers/resources/xmlhttprequest-file-not-found.js: Added. (log): (done):
  • http/tests/xmlhttprequest/workers/xmlhttprequest-file-not-found-expected.txt: Added.
  • http/tests/xmlhttprequest/workers/xmlhttprequest-file-not-found.html: Added.
Location:
trunk
Files:
5 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r41433 r41434  
     12009-03-04  David Levin  <levin@chromium.org>
     2
     3        Reviewed by Alexey Proskuryakov.
     4
     5        Bug 24337: Assert when doing sync XHR in a worker for a cacheable response.
     6        <https://bugs.webkit.org/show_bug.cgi?id=24337>
     7
     8        * http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache-expected.txt: Added.
     9        * http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html: Added.
     10        * http/tests/xmlhttprequest/workers/resources/xmlhttprequest-file-not-found.js: Added.
     11        (log):
     12        (done):
     13        * http/tests/xmlhttprequest/workers/xmlhttprequest-file-not-found-expected.txt: Added.
     14        * http/tests/xmlhttprequest/workers/xmlhttprequest-file-not-found.html: Added.
     15
    1162009-03-04  David Levin  <levin@chromium.org>
    217
  • trunk/WebCore/ChangeLog

    r41433 r41434  
     12009-03-04  David Levin  <levin@chromium.org>
     2
     3        Reviewed by Alexey Proskuryakov.
     4
     5        Bug 24337: Assert when doing sync XHR in a worker for a cacheable response.
     6        <https://bugs.webkit.org/show_bug.cgi?id=24337>
     7
     8        Tests: http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html
     9               http/tests/xmlhttprequest/workers/xmlhttprequest-file-not-found.html
     10
     11        * loader/mac/ResourceLoaderMac.mm:
     12        (WebCore::ResourceLoader::willCacheResponse):
     13        An identifier is only asssigned if resource load callbacks are done.  So don't send
     14        willCacheResponse which uses identifier if resource load callbacks aren't being sent.
     15
    1162009-03-04  David Levin  <levin@chromium.org>
    217
  • trunk/WebCore/loader/mac/ResourceLoaderMac.mm

    r39601 r41434  
    3838NSCachedURLResponse* ResourceLoader::willCacheResponse(ResourceHandle*, NSCachedURLResponse* response)
    3939{
     40    if (!m_sendResourceLoadCallbacks)
     41        return 0;
    4042    return frameLoader()->client()->willCacheResponse(documentLoader(), identifier(), response);
    4143}
Note: See TracChangeset for help on using the changeset viewer.