Changeset 41521 in webkit

Timestamp:

Mar 8, 2009 4:21:14 PM (15 years ago)

Author:

cwzwarich@webkit.org

Message:

2009-03-08 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Oliver Hunt.

Remove the unused methods previousHistoryItem(), setPreviousHistoryItem()
and provisionalHistoryItem() from FrameLoader.

• WebCore.base.exp:
• WebCore.order:
• loader/FrameLoader.cpp: (WebCore::FrameLoader::frameLoadCompleted): (WebCore::FrameLoader::loadItem):
• loader/FrameLoader.h:

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• WebCore.base.exp (modified) (1 diff)
• WebCore.order (modified) (1 diff)
• loader/FrameLoader.cpp (modified) (3 diffs)
• loader/FrameLoader.h (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-03-08  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
+
+        Reviewed by Oliver Hunt.
+
+        Remove the unused methods previousHistoryItem(), setPreviousHistoryItem()
+        and provisionalHistoryItem() from FrameLoader.
+
+        * WebCore.base.exp:
+        * WebCore.order:
+        * loader/FrameLoader.cpp:
+        (WebCore::FrameLoader::frameLoadCompleted):
+        (WebCore::FrameLoader::loadItem):
+        * loader/FrameLoader.h:
+
 2009-03-08  Gustavo Noronha Silva  <gns@gnome.org>
 

trunk/WebCore/WebCore.base.exp

@@ -160 +160 @@
 __ZN7WebCore11FrameLoader21setCurrentHistoryItemEN3WTF10PassRefPtrINS_11HistoryItemEEE
 __ZN7WebCore11FrameLoader22findFrameForNavigationERKNS_12AtomicStringE
-__ZN7WebCore11FrameLoader22setPreviousHistoryItemEN3WTF10PassRefPtrINS_11HistoryItemEEE
 __ZN7WebCore11FrameLoader23timeOfLastCompletedLoadEv
 __ZN7WebCore11FrameLoader24registerURLSchemeAsLocalERKNS_6StringE

trunk/WebCore/WebCore.order

@@ -510 +510 @@
 __ZN7WebCore11FrameLoader16markLoadCompleteEv
 __ZN7WebCore11FrameLoader18frameLoadCompletedEv
-__ZN7WebCore11FrameLoader22setPreviousHistoryItemEN3WTF10PassRefPtrINS_11HistoryItemEEE
 __ZN7WebCore14DocumentLoader22stopRecordingResponsesEv
 __ZN7WebCore11FrameLoader5beginERKNS_4KURLEbPNS_14SecurityOriginE

trunk/WebCore/loader/FrameLoader.cpp

@@ -3374 +3374 @@
     // Even if already complete, we might have set a previous item on a frame that
     // didn't do any data loading on the past transaction. Make sure to clear these out.
-    setPreviousHistoryItem(0);
+    m_previousHistoryItem = 0;
 
     // After a canceled provisional load, firstLayoutDone is false.
@@ -4852 +4852 @@
 }
 
-// FIXME: These 6 setter/getters are here for a dwindling number of users in WebKit, WebFrame
+// FIXME: These 3 setter/getters are here for a dwindling number of users in WebKit, WebFrame
 // being the primary one.  After they're no longer needed there, they can be removed!
 HistoryItem* FrameLoader::currentHistoryItem()
@@ -4859 +4859 @@
 }
 
-HistoryItem* FrameLoader::previousHistoryItem()
-{
-    return m_previousHistoryItem.get();
-}
-
-HistoryItem* FrameLoader::provisionalHistoryItem()
-{
-    return m_provisionalHistoryItem.get();
-}
-
 void FrameLoader::setCurrentHistoryItem(PassRefPtr<HistoryItem> item)
 {
     m_currentHistoryItem = item;
-}
-
-void FrameLoader::setPreviousHistoryItem(PassRefPtr<HistoryItem> item)
-{
-    m_previousHistoryItem = item;
 }
 

trunk/WebCore/loader/FrameLoader.h

@@ -408 +408 @@
         // being the primary one.  After they're no longer needed there, they can be removed!
         HistoryItem* currentHistoryItem();
-        HistoryItem* previousHistoryItem();
-        HistoryItem* provisionalHistoryItem();
         void setCurrentHistoryItem(PassRefPtr<HistoryItem>);
-        void setPreviousHistoryItem(PassRefPtr<HistoryItem>);
         void setProvisionalHistoryItem(PassRefPtr<HistoryItem>);