Changeset 41545 in webkit


Ignore:
Timestamp:
Mar 9, 2009 10:50:27 PM (15 years ago)
Author:
Simon Fraser
Message:

2009-03-09 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein, Oliver Hunt

https://bugs.webkit.org/show_bug.cgi?id=24475

When repainting replaced elements, need to union the selection
and overflow rects because either may extend outside the other.

Test: fast/repaint/transform-replaced-shadows.html

  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::clippedOverflowRectForRepaint):
Location:
trunk
Files:
4 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r41544 r41545  
     12009-03-09  Simon Fraser  <simon.fraser@apple.com>
     2
     3        Reviewed by Dan Bernstein, Oliver Hunt
     4
     5        https://bugs.webkit.org/show_bug.cgi?id=24475
     6       
     7        Test for repainting a replaced element with transform and box-shadow.
     8
     9        * fast/repaint/transform-replaced-shadows.html: Added.
     10        * platform/mac/fast/repaint/transform-replaced-shadows-expected.checksum: Added.
     11        * platform/mac/fast/repaint/transform-replaced-shadows-expected.png: Added.
     12        * platform/mac/fast/repaint/transform-replaced-shadows-expected.txt: Added.
     13
    1142009-03-09  Oliver Hunt  <oliver@apple.com>
    215
  • trunk/WebCore/ChangeLog

    r41543 r41545  
     12009-03-09  Simon Fraser  <simon.fraser@apple.com>
     2
     3        Reviewed by Dan Bernstein, Oliver Hunt
     4
     5        https://bugs.webkit.org/show_bug.cgi?id=24475
     6       
     7        When repainting replaced elements, need to union the selection
     8        and overflow rects because either may extend outside the other.
     9       
     10        Test: fast/repaint/transform-replaced-shadows.html
     11
     12        * rendering/RenderReplaced.cpp:
     13        (WebCore::RenderReplaced::clippedOverflowRectForRepaint):
     14
    1152009-03-09  Stephanie Lewis  <slewis@apple.com>
    216
  • trunk/WebCore/rendering/RenderReplaced.cpp

    r41524 r41545  
    391391        return IntRect();
    392392
    393     // The selectionRect can project outside of the overflowRect, so use
    394     // that for repainting to avoid selection painting glitches
    395     IntRect r = localSelectionRect(false);
     393    // The selectionRect can project outside of the overflowRect, so take their union
     394    // for repainting to avoid selection painting glitches.
     395    IntRect r = unionRect(localSelectionRect(false), overflowRect(false));
    396396
    397397    RenderView* v = view();
Note: See TracChangeset for help on using the changeset viewer.