Changeset 41719 in webkit

Timestamp:

Mar 15, 2009 10:40:33 AM (15 years ago)

Author:

kov@webkit.org

Message:

2009-03-15 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Anders Carlsson.

​https://bugs.webkit.org/show_bug.cgi?id=24602
[Gtk] Searching in thepiratebay.org doesn't work with more than 1 word

Reintroduce the URI into the soup message after having set it in
the KURL, on redirects, to make sure it is properly encoded. This
fixes bad request problems when servers give bad URIs on their
response's Location header.

• platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/soup/ResourceHandleSoup.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-03-15  Gustavo Noronha Silva  <gns@gnome.org>
+
+        Reviewed by Anders Carlsson.
+
+        https://bugs.webkit.org/show_bug.cgi?id=24602
+        [Gtk] Searching in thepiratebay.org doesn't work with more than 1 word
+
+        Reintroduce the URI into the soup message after having set it in
+        the KURL, on redirects, to make sure it is properly encoded. This
+        fixes bad request problems when servers give bad URIs on their
+        response's Location header.
+
+        * platform/network/soup/ResourceHandleSoup.cpp:
+        (WebCore::restartedCallback):
+
 2009-03-15  Alexey Proskuryakov  <ap@webkit.org>
 

trunk/WebCore/platform/network/soup/ResourceHandleSoup.cpp

@@ -188 +188 @@
     KURL newURL = KURL(handle->request().url(), location);
 
+    // FIXME: This is needed because some servers use broken URIs in
+    // their Location header, when redirecting, such as URIs with
+    // white spaces instead of %20; this should be fixed in soup, in
+    // the future, and this work-around removed.
+    // See http://bugzilla.gnome.org/show_bug.cgi?id=575378.
+    SoupURI* soup_uri = soup_uri_new(newURL.string().utf8().data());
+    soup_message_set_uri(msg, soup_uri);
+    soup_uri_free(soup_uri);
+
     ResourceRequest request = handle->request();
     ResourceResponse response;