Changeset 41879 in webkit


Ignore:
Timestamp:
Mar 20, 2009 4:45:58 PM (15 years ago)
Author:
levin@chromium.org
Message:

JavaScriptCore:

2009-03-20 Norbert Leser <​norbert.leser@nokia.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=24535

Fixes missing line terminator character (;) after macro call.
It is common practice to add the trailing ";" where macros are substituted
and not where they are defined with #define.
This change is consistent with other macro declarations across webkit,
and it also solves compilation failure with symbian compilers.

  • runtime/UString.cpp:
  • wtf/Assertions.h:

WebCore:

2009-03-20 Norbert Leser <​norbert.leser@nokia.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=24535

Fixes missing line terminator character (;) after macro call.
It is common practice to add the trailing ";" where macros are substituted
and not where they are defined with #define.
This change is consistent with other macro declarations across webkit,
and it also solves compilation failure with symbian compilers.

No change in behavior, so no test.

  • bindings/js/JSDOMWindowShell.cpp:
  • bindings/js/JSEventListener.cpp:
  • bindings/js/JSImageConstructor.cpp:
  • bindings/js/JSInspectedObjectWrapper.cpp:
  • bindings/js/JSInspectorCallbackWrapper.cpp:
  • bindings/js/JSNamedNodesCollection.cpp:
  • bindings/js/JSNodeFilterCondition.cpp:
  • bindings/js/JSOptionConstructor.cpp:
  • bindings/js/JSQuarantinedObjectWrapper.cpp:
  • bindings/js/JSRGBColor.cpp:
  • bindings/js/JSWorkerContextBase.cpp:
  • bindings/js/JSXMLHttpRequestConstructor.cpp:
  • bindings/js/JSXSLTProcessorConstructor.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:
Location:
trunk
Files:
18 edited

Legend:

Unmodified
Added
Removed

  • trunk/JavaScriptCore/ChangeLog

    r41872 r41879  
     12009-03-20  Norbert Leser  <norbert.leser@nokia.com>
     2
     3        Reviewed by Darin Adler.
     4
     5        https://bugs.webkit.org/show_bug.cgi?id=24535
     6
     7        Fixes missing line terminator character (;) after macro call.
     8        It is common practice to add the trailing ";" where macros are substituted
     9        and not where they are defined with #define.
     10        This change is consistent with other macro declarations across webkit,
     11        and it also solves compilation failure with symbian compilers.
     12 
     13        * runtime/UString.cpp:
     14        * wtf/Assertions.h:
     15
    1162009-03-20  Geoffrey Garen  <ggaren@apple.com>
    217

  • trunk/JavaScriptCore/runtime/UString.cpp

    r40975 r41879  
    9494}
    9595
    96 COMPILE_ASSERT(sizeof(UChar) == 2, uchar_is_2_bytes)
     96COMPILE_ASSERT(sizeof(UChar) == 2, uchar_is_2_bytes);
    9797
    9898CString::CString(const char* c)

  • trunk/JavaScriptCore/wtf/Assertions.h

    r39600 r41879  
    195195/* COMPILE_ASSERT */
    196196#ifndef COMPILE_ASSERT
    197 #define COMPILE_ASSERT(exp, name) typedef int dummy##name [(exp) ? 1 : -1];
     197#define COMPILE_ASSERT(exp, name) typedef int dummy##name [(exp) ? 1 : -1]
    198198#endif
    199199

  • trunk/WebCore/ChangeLog

    r41878 r41879  
     12009-03-20  Norbert Leser  <norbert.leser@nokia.com>
     2
     3        Reviewed by Darin Adler.
     4
     5        https://bugs.webkit.org/show_bug.cgi?id=24535
     6
     7        Fixes missing line terminator character (;) after macro call.
     8        It is common practice to add the trailing ";" where macros are substituted
     9        and not where they are defined with #define.
     10        This change is consistent with other macro declarations across webkit,
     11        and it also solves compilation failure with symbian compilers.
     12 
     13        No change in behavior, so no test.
     14
     15        * bindings/js/JSDOMWindowShell.cpp:
     16        * bindings/js/JSEventListener.cpp:
     17        * bindings/js/JSImageConstructor.cpp:
     18        * bindings/js/JSInspectedObjectWrapper.cpp:
     19        * bindings/js/JSInspectorCallbackWrapper.cpp:
     20        * bindings/js/JSNamedNodesCollection.cpp:
     21        * bindings/js/JSNodeFilterCondition.cpp:
     22        * bindings/js/JSOptionConstructor.cpp:
     23        * bindings/js/JSQuarantinedObjectWrapper.cpp:
     24        * bindings/js/JSRGBColor.cpp:
     25        * bindings/js/JSWorkerContextBase.cpp:
     26        * bindings/js/JSXMLHttpRequestConstructor.cpp:
     27        * bindings/js/JSXSLTProcessorConstructor.cpp:
     28        * bindings/scripts/CodeGeneratorJS.pm:
     29
    1302009-03-20  Mike Belshe  <mike@belshe.com>
    231

  • trunk/WebCore/bindings/js/JSDOMWindowShell.cpp

    r39670 r41879  
    4040namespace WebCore {
    4141
    42 ASSERT_CLASS_FITS_IN_CELL(JSDOMWindowShell)
     42ASSERT_CLASS_FITS_IN_CELL(JSDOMWindowShell);
    4343
    4444const ClassInfo JSDOMWindowShell::s_info = { "JSDOMWindowShell", 0, 0, 0 };

  • trunk/WebCore/bindings/js/JSEventListener.cpp

    r41126 r41879  
    4141namespace WebCore {
    4242
    43 ASSERT_CLASS_FITS_IN_CELL(JSAbstractEventListener)
     43ASSERT_CLASS_FITS_IN_CELL(JSAbstractEventListener);
    4444
    4545void JSAbstractEventListener::handleEvent(Event* event, bool isWindowEvent)

  • trunk/WebCore/bindings/js/JSImageConstructor.cpp

    r41732 r41879  
    3131namespace WebCore {
    3232
    33 ASSERT_CLASS_FITS_IN_CELL(JSImageConstructor)
     33ASSERT_CLASS_FITS_IN_CELL(JSImageConstructor);
    3434
    3535const ClassInfo JSImageConstructor::s_info = { "ImageConstructor", 0, 0, 0 };

  • trunk/WebCore/bindings/js/JSInspectedObjectWrapper.cpp

    r41404 r41879  
    3535namespace WebCore {
    3636
    37 ASSERT_CLASS_FITS_IN_CELL(JSInspectedObjectWrapper)
     37ASSERT_CLASS_FITS_IN_CELL(JSInspectedObjectWrapper);
    3838
    3939typedef HashMap<JSObject*, JSInspectedObjectWrapper*> WrapperMap;

  • trunk/WebCore/bindings/js/JSInspectorCallbackWrapper.cpp

    r40046 r41879  
    3434namespace WebCore {
    3535
    36 ASSERT_CLASS_FITS_IN_CELL(JSInspectorCallbackWrapper)
     36ASSERT_CLASS_FITS_IN_CELL(JSInspectorCallbackWrapper);
    3737
    3838typedef HashMap<JSObject*, JSInspectorCallbackWrapper*> WrapperMap;

  • trunk/WebCore/bindings/js/JSNamedNodesCollection.cpp

    r39670 r41879  
    3636using namespace JSC;
    3737
    38 ASSERT_CLASS_FITS_IN_CELL(JSNamedNodesCollection)
     38ASSERT_CLASS_FITS_IN_CELL(JSNamedNodesCollection);
    3939
    4040const ClassInfo JSNamedNodesCollection::s_info = { "Collection", 0, 0, 0 };

  • trunk/WebCore/bindings/js/JSNodeFilterCondition.cpp

    r40046 r41879  
    3030using namespace JSC;
    3131
    32 ASSERT_CLASS_FITS_IN_CELL(JSNodeFilterCondition)
     32ASSERT_CLASS_FITS_IN_CELL(JSNodeFilterCondition);
    3333
    3434JSNodeFilterCondition::JSNodeFilterCondition(JSValuePtr filter)

  • trunk/WebCore/bindings/js/JSOptionConstructor.cpp

    r41732 r41879  
    3131namespace WebCore {
    3232
    33 ASSERT_CLASS_FITS_IN_CELL(JSOptionConstructor)
     33ASSERT_CLASS_FITS_IN_CELL(JSOptionConstructor);
    3434
    3535const ClassInfo JSOptionConstructor::s_info = { "OptionConstructor", 0, 0, 0 };

  • trunk/WebCore/bindings/js/JSQuarantinedObjectWrapper.cpp

    r41404 r41879  
    3333namespace WebCore {
    3434
    35 ASSERT_CLASS_FITS_IN_CELL(JSQuarantinedObjectWrapper)
     35ASSERT_CLASS_FITS_IN_CELL(JSQuarantinedObjectWrapper);
    3636
    3737const ClassInfo JSQuarantinedObjectWrapper::s_info = { "JSQuarantinedObjectWrapper", 0, 0, 0 };

  • trunk/WebCore/bindings/js/JSRGBColor.cpp

    r39670 r41879  
    4545namespace WebCore {
    4646
    47 ASSERT_CLASS_FITS_IN_CELL(JSRGBColor)
     47ASSERT_CLASS_FITS_IN_CELL(JSRGBColor);
    4848
    4949const ClassInfo JSRGBColor::s_info = { "RGBColor", 0, &JSRGBColorTable, 0 };

  • trunk/WebCore/bindings/js/JSWorkerContextBase.cpp

    r41344 r41879  
    6060namespace WebCore {
    6161
    62 ASSERT_CLASS_FITS_IN_CELL(JSWorkerContextBase)
     62ASSERT_CLASS_FITS_IN_CELL(JSWorkerContextBase);
    6363
    6464JSWorkerContextBase::JSWorkerContextBase(PassRefPtr<JSC::Structure> structure, PassRefPtr<WorkerContext> impl)

  • trunk/WebCore/bindings/js/JSXMLHttpRequestConstructor.cpp

    r41732 r41879  
    2929namespace WebCore {
    3030
    31 ASSERT_CLASS_FITS_IN_CELL(JSXMLHttpRequestConstructor)
     31ASSERT_CLASS_FITS_IN_CELL(JSXMLHttpRequestConstructor);
    3232
    3333const ClassInfo JSXMLHttpRequestConstructor::s_info = { "XMLHttpRequestConstructor", 0, 0, 0 };

  • trunk/WebCore/bindings/js/JSXSLTProcessorConstructor.cpp

    r39601 r41879  
    3838namespace WebCore {
    3939
    40 ASSERT_CLASS_FITS_IN_CELL(JSXSLTProcessorConstructor)
     40ASSERT_CLASS_FITS_IN_CELL(JSXSLTProcessorConstructor);
    4141
    4242const ClassInfo JSXSLTProcessorConstructor::s_info = { "XSLTProcessorConsructor", 0, 0, 0 };

  • trunk/WebCore/bindings/scripts/CodeGeneratorJS.pm

    r41462 r41879  
    758758    push(@implContent, "namespace WebCore {\n\n");
    759759
    760     push(@implContent, "ASSERT_CLASS_FITS_IN_CELL($className)\n\n");
     760    push(@implContent, "ASSERT_CLASS_FITS_IN_CELL($className);\n\n");
    761761
    762762    # - Add all attributes in a hashtable definition
Note: See TracChangeset for help on using the changeset viewer.