Changeset 42057 in webkit

Timestamp:

Mar 27, 2009 4:55:17 PM (15 years ago)

Author:

Darin Adler

Message:

2009-03-27 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Made our mailto form submission tests work more reliably by using the new
layoutTestController.waitForPolicyDelegate function.

• fast/encoding/mailto-always-utf-8.html: Updated test to use waitForPolicyDelegate rather than relying on the form submission happening immediately.
• fast/forms/mailto/advanced-get.html: Ditto.
• fast/forms/mailto/advanced-put.html: Ditto.
• fast/forms/mailto/get-multiple-items-text-plain.html: Ditto.
• fast/forms/mailto/get-multiple-items-x-www-form-urlencoded.html: Ditto.
• fast/forms/mailto/get-multiple-items.html: Ditto.
• fast/forms/mailto/get-non-ascii-always-utf-8.html: Ditto.
• fast/forms/mailto/get-non-ascii-text-plain-latin-1.html: Ditto.
• fast/forms/mailto/get-non-ascii-text-plain.html: Ditto.
• fast/forms/mailto/get-non-ascii.html: Ditto.
• fast/forms/mailto/get-overwrite-query.html: Ditto.
• fast/forms/mailto/post-append-query.html: Ditto.
• fast/forms/mailto/post-multiple-items-multipart-form-data.html: Ditto.
• fast/forms/mailto/post-multiple-items-text-plain.html: Ditto.
• fast/forms/mailto/post-multiple-items-x-www-form-urlencoded.html: Ditto.
• fast/forms/mailto/post-multiple-items.html: Ditto.
• fast/forms/mailto/post-text-plain-with-accept-charset.html: Ditto.
• fast/forms/mailto/post-text-plain.html: Ditto.

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• fast/encoding/mailto-always-utf-8.html (modified) (1 diff)
• fast/forms/mailto/advanced-get.html (modified) (1 diff)
• fast/forms/mailto/advanced-put.html (modified) (1 diff)
• fast/forms/mailto/get-multiple-items-text-plain.html (modified) (1 diff)
• fast/forms/mailto/get-multiple-items-x-www-form-urlencoded.html (modified) (1 diff)
• fast/forms/mailto/get-multiple-items.html (modified) (1 diff)
• fast/forms/mailto/get-non-ascii-always-utf-8.html (modified) (1 diff)
• fast/forms/mailto/get-non-ascii-text-plain-latin-1.html (modified) (1 diff)
• fast/forms/mailto/get-non-ascii-text-plain.html (modified) (1 diff)
• fast/forms/mailto/get-non-ascii.html (modified) (1 diff)
• fast/forms/mailto/get-overwrite-query.html (modified) (1 diff)
• fast/forms/mailto/post-append-query.html (modified) (1 diff)
• fast/forms/mailto/post-multiple-items-multipart-form-data.html (modified) (1 diff)
• fast/forms/mailto/post-multiple-items-text-plain.html (modified) (1 diff)
• fast/forms/mailto/post-multiple-items-x-www-form-urlencoded.html (modified) (1 diff)
• fast/forms/mailto/post-multiple-items.html (modified) (1 diff)
• fast/forms/mailto/post-text-plain-with-accept-charset.html (modified) (1 diff)
• fast/forms/mailto/post-text-plain.html (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2009-03-27  Darin Adler  <darin@apple.com>
+
+        Reviewed by Sam Weinig.
+
+        Made our mailto form submission tests work more reliably by using the new
+        layoutTestController.waitForPolicyDelegate function.
+
+        * fast/encoding/mailto-always-utf-8.html: Updated test to use waitForPolicyDelegate
+        rather than relying on the form submission happening immediately.
+        * fast/forms/mailto/advanced-get.html: Ditto.
+        * fast/forms/mailto/advanced-put.html: Ditto.
+        * fast/forms/mailto/get-multiple-items-text-plain.html: Ditto.
+        * fast/forms/mailto/get-multiple-items-x-www-form-urlencoded.html: Ditto.
+        * fast/forms/mailto/get-multiple-items.html: Ditto.
+        * fast/forms/mailto/get-non-ascii-always-utf-8.html: Ditto.
+        * fast/forms/mailto/get-non-ascii-text-plain-latin-1.html: Ditto.
+        * fast/forms/mailto/get-non-ascii-text-plain.html: Ditto.
+        * fast/forms/mailto/get-non-ascii.html: Ditto.
+        * fast/forms/mailto/get-overwrite-query.html: Ditto.
+        * fast/forms/mailto/post-append-query.html: Ditto.
+        * fast/forms/mailto/post-multiple-items-multipart-form-data.html: Ditto.
+        * fast/forms/mailto/post-multiple-items-text-plain.html: Ditto.
+        * fast/forms/mailto/post-multiple-items-x-www-form-urlencoded.html: Ditto.
+        * fast/forms/mailto/post-multiple-items.html: Ditto.
+        * fast/forms/mailto/post-text-plain-with-accept-charset.html: Ditto.
+        * fast/forms/mailto/post-text-plain.html: Ditto.
+
 2009-03-27  Xiaomei Ji  <xji@chromium.org>
 

trunk/LayoutTests/fast/encoding/mailto-always-utf-8.html

@@ -16 +16 @@
   if (window.layoutTestController) {
     layoutTestController.dumpAsText();
-    layoutTestController.setCustomPolicyDelegate(true);
+    layoutTestController.waitForPolicyDelegate();
     var a = document.getElementsByTagName("a")[0];
     eventSender.mouseMoveTo(a.offsetLeft + 5, a.offsetTop + 5);
     eventSender.mouseDown();
     eventSender.mouseUp();
-    layoutTestController.setCustomPolicyDelegate(false);
   }
 }

trunk/LayoutTests/fast/forms/mailto/advanced-get.html

@@ -7 +7 @@
               if (window.layoutTestController) {
                 layoutTestController.dumpAsText();
-                layoutTestController.setCustomPolicyDelegate(true);
+                layoutTestController.waitForPolicyDelegate();
                 document.getElementsByTagName("form")[0].submit();
-                layoutTestController.setCustomPolicyDelegate(false);
               }
             }

trunk/LayoutTests/fast/forms/mailto/advanced-put.html

@@ -7 +7 @@
               if (window.layoutTestController) {
                 layoutTestController.dumpAsText();
-                layoutTestController.setCustomPolicyDelegate(true);
+                layoutTestController.waitForPolicyDelegate();
                 document.getElementsByTagName("form")[0].submit();
-                layoutTestController.setCustomPolicyDelegate(false);
               }
             }

trunk/LayoutTests/fast/forms/mailto/get-multiple-items-text-plain.html

@@ -11 +11 @@
   if (window.layoutTestController) {
     layoutTestController.dumpAsText();
-    layoutTestController.setCustomPolicyDelegate(true);
+    layoutTestController.waitForPolicyDelegate();
     document.getElementsByTagName("form")[0].submit();
-    layoutTestController.setCustomPolicyDelegate(false);
   }
 }

trunk/LayoutTests/fast/forms/mailto/get-multiple-items-x-www-form-urlencoded.html

@@ -9 +9 @@
   if (window.layoutTestController) {
     layoutTestController.dumpAsText();
-    layoutTestController.setCustomPolicyDelegate(true);
+    layoutTestController.waitForPolicyDelegate();
     document.getElementsByTagName("form")[0].submit();
-    layoutTestController.setCustomPolicyDelegate(false);
   }
 }

trunk/LayoutTests/fast/forms/mailto/get-multiple-items.html

@@ -10 +10 @@
   if (window.layoutTestController) {
     layoutTestController.dumpAsText();
-    layoutTestController.setCustomPolicyDelegate(true);
+    layoutTestController.waitForPolicyDelegate();
     document.getElementsByTagName("form")[0].submit();
-    layoutTestController.setCustomPolicyDelegate(false);
   }
 }

trunk/LayoutTests/fast/forms/mailto/get-non-ascii-always-utf-8.html

@@ -10 +10 @@
   if (window.layoutTestController) {
     layoutTestController.dumpAsText();
-    layoutTestController.setCustomPolicyDelegate(true);
+    layoutTestController.waitForPolicyDelegate();
     document.getElementsByTagName("form")[0].submit();
-    layoutTestController.setCustomPolicyDelegate(false);
   }
 }

trunk/LayoutTests/fast/forms/mailto/get-non-ascii-text-plain-latin-1.html

@@ -10 +10 @@
   if (window.layoutTestController) {
     layoutTestController.dumpAsText();
-    layoutTestController.setCustomPolicyDelegate(true);
+    layoutTestController.waitForPolicyDelegate();
     document.getElementsByTagName("form")[0].submit();
-    layoutTestController.setCustomPolicyDelegate(false);
   }
 }

trunk/LayoutTests/fast/forms/mailto/get-non-ascii-text-plain.html

@@ -10 +10 @@
   if (window.layoutTestController) {
     layoutTestController.dumpAsText();
-    layoutTestController.setCustomPolicyDelegate(true);
+    layoutTestController.waitForPolicyDelegate();
     document.getElementsByTagName("form")[0].submit();
-    layoutTestController.setCustomPolicyDelegate(false);
   }
 }

trunk/LayoutTests/fast/forms/mailto/get-non-ascii.html

@@ -10 +10 @@
   if (window.layoutTestController) {
     layoutTestController.dumpAsText();
-    layoutTestController.setCustomPolicyDelegate(true);
+    layoutTestController.waitForPolicyDelegate();
     document.getElementsByTagName("form")[0].submit();
-    layoutTestController.setCustomPolicyDelegate(false);
   }
 }

trunk/LayoutTests/fast/forms/mailto/get-overwrite-query.html

@@ -9 +9 @@
   if (window.layoutTestController) {
     layoutTestController.dumpAsText();
-    layoutTestController.setCustomPolicyDelegate(true);
+    layoutTestController.waitForPolicyDelegate();
     document.getElementsByTagName("form")[0].submit();
-    layoutTestController.setCustomPolicyDelegate(false);
   }
 }

trunk/LayoutTests/fast/forms/mailto/post-append-query.html

@@ -9 +9 @@
   if (window.layoutTestController) {
     layoutTestController.dumpAsText();
-    layoutTestController.setCustomPolicyDelegate(true);
+    layoutTestController.waitForPolicyDelegate();
     document.getElementsByTagName("form")[0].submit();
-    layoutTestController.setCustomPolicyDelegate(false);
   }
 }

trunk/LayoutTests/fast/forms/mailto/post-multiple-items-multipart-form-data.html

@@ -11 +11 @@
   if (window.layoutTestController) {
     layoutTestController.dumpAsText();
-    layoutTestController.setCustomPolicyDelegate(true);
+    layoutTestController.waitForPolicyDelegate();
     document.getElementsByTagName("form")[0].submit();
-    layoutTestController.setCustomPolicyDelegate(false);
   }
 }

trunk/LayoutTests/fast/forms/mailto/post-multiple-items-text-plain.html

@@ -11 +11 @@
   if (window.layoutTestController) {
     layoutTestController.dumpAsText();
-    layoutTestController.setCustomPolicyDelegate(true);
+    layoutTestController.waitForPolicyDelegate();
     document.getElementsByTagName("form")[0].submit();
-    layoutTestController.setCustomPolicyDelegate(false);
   }
 }

trunk/LayoutTests/fast/forms/mailto/post-multiple-items-x-www-form-urlencoded.html

@@ -11 +11 @@
   if (window.layoutTestController) {
     layoutTestController.dumpAsText();
-    layoutTestController.setCustomPolicyDelegate(true);
+    layoutTestController.waitForPolicyDelegate();
     document.getElementsByTagName("form")[0].submit();
-    layoutTestController.setCustomPolicyDelegate(false);
   }
 }

trunk/LayoutTests/fast/forms/mailto/post-multiple-items.html

@@ -10 +10 @@
   if (window.layoutTestController) {
     layoutTestController.dumpAsText();
-    layoutTestController.setCustomPolicyDelegate(true);
+    layoutTestController.waitForPolicyDelegate();
     document.getElementsByTagName("form")[0].submit();
-    layoutTestController.setCustomPolicyDelegate(false);
   }
 }

trunk/LayoutTests/fast/forms/mailto/post-text-plain-with-accept-charset.html

@@ -14 +14 @@
   if (window.layoutTestController) {
     layoutTestController.dumpAsText();
-    layoutTestController.setCustomPolicyDelegate(true);
+    layoutTestController.waitForPolicyDelegate();
     document.getElementsByTagName("form")[0].submit();
-    layoutTestController.setCustomPolicyDelegate(false);
   }
 }

trunk/LayoutTests/fast/forms/mailto/post-text-plain.html

@@ -14 +14 @@
   if (window.layoutTestController) {
     layoutTestController.dumpAsText();
-    layoutTestController.setCustomPolicyDelegate(true);
+    layoutTestController.waitForPolicyDelegate();
     document.getElementsByTagName("form")[0].submit();
-    layoutTestController.setCustomPolicyDelegate(false);
   }
 }