Changeset 42177 in webkit

Timestamp:

Apr 2, 2009 11:22:22 AM (15 years ago)

Author:

pam@chromium.org

Message:

2009-04-02 Pamela Greene <​pam@chromium.org>

Reviewed by Darin Adler.

Split long-running regexp out of the main regexp-overflow test file
so VMs (such as V8) that don't limit execution time can still run
the rest of the test cases.
​https://bugs.webkit.org/show_bug.cgi?id=18327

• fast/js/regexp-overflow-expected.txt: updated
• fast/js/regexp-overflow-too-big-expected.txt: Added.
• fast/js/regexp-overflow-too-big.html: Added.
• fast/js/resources/regexp-overflow-too-big.js: Added.
• fast/js/resources/regexp-overflow.js: removed one test case

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• fast/js/regexp-overflow-expected.txt (modified) (1 diff)
• fast/js/regexp-overflow-too-big-expected.txt (added)
• fast/js/regexp-overflow-too-big.html (added)
• fast/js/resources/regexp-overflow-too-big.js (added)
• fast/js/resources/regexp-overflow.js (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2009-04-02  Pamela Greene  <pam@chromium.org>
+
+        Reviewed by Darin Adler.
+
+        Split long-running regexp out of the main regexp-overflow test file
+        so VMs (such as V8) that don't limit execution time can still run
+        the rest of the test cases.
+        https://bugs.webkit.org/show_bug.cgi?id=18327
+
+        * fast/js/regexp-overflow-expected.txt: updated
+        * fast/js/regexp-overflow-too-big-expected.txt: Added.
+        * fast/js/regexp-overflow-too-big.html: Added.
+        * fast/js/resources/regexp-overflow-too-big.js: Added.
+        * fast/js/resources/regexp-overflow.js: removed one test case
+
 2009-04-02  Pamela Greene  <pam@chromium.org>
 

trunk/LayoutTests/fast/js/regexp-overflow-expected.txt

@@ -14 +14 @@
 PASS /|[x\B-\u00b5]/i.exec("").toString() is ""
 PASS new RegExp(complexPattern).exec(complexInput)[0] is complexInput
-PASS new RegExp(complexPattern + complexPattern).exec(complexInput + complexInput) is null
 PASS new RegExp(s); threw exception SyntaxError: Invalid regular expression: regular expression too large.
 PASS /(([ab]){30}){3360}/ threw exception SyntaxError: Invalid regular expression: regular expression too large.

trunk/LayoutTests/fast/js/resources/regexp-overflow.js

@@ -33 +33 @@
 
 shouldBe('new RegExp(complexPattern).exec(complexInput)[0]', 'complexInput'); // Big but OK
-shouldBe('new RegExp(complexPattern + complexPattern).exec(complexInput + complexInput)', 'null'); // Too big
+// The analogous "too big" case is tested separately in
+// regexp-overflow-too-big.html so engines that don't limit regexp execution
+// time don't time out in this test. See
+// https://bugs.webkit.org/show_bug.cgi?id=18327 .
 
 var s = "a";