Changeset 42562 in webkit

Timestamp:

Apr 15, 2009 3:46:34 PM (15 years ago)

Author:

kevino@webkit.org

Message:

Reviewed by Kevin Ollivier.

Implement support for wxWebViewNewWindowEvent.

​https://bugs.webkit.org/show_bug.cgi?id=19043

Location:

trunk/WebKit/wx

Files:

• ChangeLog (modified) (1 diff)
• WebKitSupport/FrameLoaderClientWx.cpp (modified) (1 diff)

trunk/WebKit/wx/ChangeLog

@@ +1 @@
+2009-04-15  Robin Dunn  <robin@alldunn.com>
+
+        Reviewed by Kevin Ollivier.
+        
+        Implement support for wxWebViewNewWindowEvent.
+        
+        https://bugs.webkit.org/show_bug.cgi?id=19043
+
+        * WebKitSupport/FrameLoaderClientWx.cpp:
+        (WebCore::FrameLoaderClientWx::dispatchDecidePolicyForNewWindowAction):
+
 2009-04-04  Kevin Ollivier  <kevino@theolliviers.com>
 

trunk/WebKit/wx/WebKitSupport/FrameLoaderClientWx.cpp

@@ -691 +691 @@
 }
 
-void FrameLoaderClientWx::dispatchDecidePolicyForNewWindowAction(FramePolicyFunction function, const NavigationAction&, const ResourceRequest&, PassRefPtr<FormState>, const String&)
+void FrameLoaderClientWx::dispatchDecidePolicyForNewWindowAction(FramePolicyFunction function, const NavigationAction&, const ResourceRequest& request, PassRefPtr<FormState>, const String& targetName)
 {
     if (!m_frame)
         return;
 
-    notImplemented();
+    if (m_webView) {
+        wxWebViewNewWindowEvent wkEvent(m_webView);
+        wkEvent.SetURL(request.url().string());
+        wkEvent.SetTargetName(targetName);
+        if (m_webView->GetEventHandler()->ProcessEvent(wkEvent)) {
+            // if the app handles and doesn't skip the event, 
+            // from WebKit's perspective treat it as blocked / ignored
+            (m_frame->loader()->*function)(PolicyIgnore);
+            return;
+        }
+    }
+    
     (m_frame->loader()->*function)(PolicyUse);
 }