Changeset 43419 in webkit

Timestamp:

May 8, 2009 4:40:39 PM (15 years ago)

Author:

Beth Dakin

Message:

2009-05-08 Douglas R. Davidson <​ddavidso@apple.com>

Reviewed by Beth Dakin.

<rdar://problem/6857446> REGRESSION (Safari 3-4): Contraction base
marked as misspelled even though contraction is a word
Make sure spelling underline does not persist on words like
<doesn't>.

• editing/TypingCommand.cpp: (WebCore::TypingCommand::typingAddedToOpenCommand):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• editing/TypingCommand.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-05-08  Douglas R. Davidson  <ddavidso@apple.com>
+
+        Reviewed by Beth Dakin.
+
+        <rdar://problem/6857446> REGRESSION (Safari 3-4): Contraction base 
+        marked as misspelled even though contraction is a word
+        Make sure spelling underline does not persist on words like 
+        <doesn't>.  
+
+        * editing/TypingCommand.cpp:
+        (WebCore::TypingCommand::typingAddedToOpenCommand):
+
 2009-05-08  Kevin Watters  <kevinwatters@gmail.com>
 

trunk/WebCore/editing/TypingCommand.cpp

@@ -312 +312 @@
 void TypingCommand::typingAddedToOpenCommand()
 {
+#if PLATFORM(MAC) && !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD)
     document()->frame()->editor()->appliedEditing(this);
     // Since the spellchecking code may also perform corrections and other replacements, it should happen after the typing changes.
     markMisspellingsAfterTyping();
+#else
+    // The old spellchecking code requires that checking be done first, to prevent issues like that in 6864072, where <doesn't> is marked as misspelled.
+    markMisspellingsAfterTyping();
+    document()->frame()->editor()->appliedEditing(this);
+#endif
 }