Changeset 43796 in webkit

Timestamp:

May 15, 2009 7:17:51 PM (15 years ago)

Author:

kov@webkit.org

Message:

2009-05-15 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Jan Alonzo.

Plug memory leak.

• webkit/webkitwebsettings.cpp: (free_spell_checking_language): (webkit_web_settings_finalize): (webkit_web_settings_set_property):

Location:

trunk/WebKit/gtk

Files:

• ChangeLog (modified) (1 diff)
• webkit/webkitwebsettings.cpp (modified) (3 diffs)

trunk/WebKit/gtk/ChangeLog

@@ +1 @@
+2009-05-15  Gustavo Noronha Silva  <gns@gnome.org>
+
+        Reviewed by Jan Alonzo.
+
+        Plug memory leak.
+
+        * webkit/webkitwebsettings.cpp:
+        (free_spell_checking_language):
+        (webkit_web_settings_finalize):
+        (webkit_web_settings_set_property):
+
 2009-05-15  Fridrich Strba  <fridrich.strba@bluewin.ch>
 

trunk/WebKit/gtk/webkit/webkitwebsettings.cpp

@@ -428 +428 @@
 }
 
+static void free_spell_checking_language(gpointer data, gpointer user_data)
+{
+    SpellLanguage* language = static_cast<SpellLanguage*>(data);
+    enchant_broker_free_dict(language->config, language->speller);
+    enchant_broker_free(language->config);
+    g_slice_free(SpellLanguage, language);
+}
+
 static void webkit_web_settings_finalize(GObject* object)
 {
@@ -443 +451 @@
     g_free(priv->spell_checking_languages);
 
+    g_slist_foreach(priv->spell_checking_languages_list, free_spell_checking_language, NULL);
     g_slist_free(priv->spell_checking_languages_list);
 
@@ -558 +567 @@
             spellLanguages = g_slist_append(spellLanguages, lang);
         }
+        g_slist_foreach(priv->spell_checking_languages_list, free_spell_checking_language, NULL);
         g_slist_free(priv->spell_checking_languages_list);
         priv->spell_checking_languages_list = spellLanguages;