Changeset 44052 in webkit


Ignore:
Timestamp:
May 22, 2009 12:06:07 PM (15 years ago)
Author:
xan@webkit.org
Message:

2009-05-21 Xan Lopez <xlopez@igalia.com>

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=24818
[GTK] http auth dialog pops up twice after a cancelled atempt

Workaround libsoup bug
http://bugzilla.gnome.org/show_bug.cgi?id=583462, which made
libsoup emit the 'authenticate' signal more often than it was
expected.

We'll be able to remove this when we depend on libsoup > 2.26.2.

  • webkit/webkitsoupauthdialog.c: (session_authenticate):
Location:
trunk/WebKit/gtk
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebKit/gtk/ChangeLog

    r43982 r44052  
     12009-05-21  Xan Lopez  <xlopez@igalia.com>
     2
     3        Reviewed by Maciej Stachowiak.
     4
     5        https://bugs.webkit.org/show_bug.cgi?id=24818
     6        [GTK] http auth dialog pops up twice after a cancelled atempt
     7
     8        Workaround libsoup bug
     9        http://bugzilla.gnome.org/show_bug.cgi?id=583462, which made
     10        libsoup emit the 'authenticate' signal more often than it was
     11        expected.
     12
     13        We'll be able to remove this when we depend on libsoup > 2.26.2.
     14
     15        * webkit/webkitsoupauthdialog.c:
     16        (session_authenticate):
     17
    1182009-05-21  Darin Fisher  <darin@chromium.org>
    219
  • trunk/WebKit/gtk/webkit/webkitsoupauthdialog.c

    r42391 r44052  
    316316    SoupSessionFeature* manager = (SoupSessionFeature*)user_data;
    317317
     318    /*
     319     * Workaround for http://bugzilla.gnome.org/show_bug.cgi?id=583462
     320     * FIXME: we can remove this once we depend on a libsoup newer than 2.26.2
     321     */
     322    if (msg->status_code == 0)
     323        return;
     324
    318325    soup_session_pause_message(session, msg);
    319326    /* We need to make sure the message sticks around when pausing it */
Note: See TracChangeset for help on using the changeset viewer.