Changeset 44288 in webkit


Ignore:
Timestamp:
May 30, 2009 3:38:18 PM (15 years ago)
Author:
bfulgham@webkit.org
Message:

2009-05-30 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Sam Weinig.

LocalStorage and SessionStorage's implicit setters do not correctly
handle null. The custom JS bindings should convert to strings
unconditionally and not try to handle null specially.
https://bugs.webkit.org/show_bug.cgi?id=25970

Tests: storage/domstorage/localstorage/string-conversion.html

storage/domstorage/sessionstorage/string-conversion.html

  • bindings/js/JSStorageCustom.cpp: (WebCore::JSStorage::customPut):
Location:
trunk/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r44287 r44288  
     12009-05-30  Jeremy Orlow  <jorlow@chromium.org>
     2
     3        Reviewed by Sam Weinig.
     4
     5        LocalStorage and SessionStorage's implicit setters do not correctly
     6        handle null.  The custom JS bindings should convert to strings
     7        unconditionally and not try to handle null specially.
     8        https://bugs.webkit.org/show_bug.cgi?id=25970
     9
     10        Tests: storage/domstorage/localstorage/string-conversion.html
     11               storage/domstorage/sessionstorage/string-conversion.html
     12
     13        * bindings/js/JSStorageCustom.cpp:
     14        (WebCore::JSStorage::customPut):
     15
    1162009-05-30  Dan Bernstein  <mitz@apple.com>
    217
  • trunk/WebCore/bindings/js/JSStorageCustom.cpp

    r43122 r44288  
    8888        return false;
    8989   
    90     String stringValue = valueToStringWithNullCheck(exec, value);
     90    String stringValue = value.toString(exec);
    9191    if (exec->hadException())
    9292        return true;
Note: See TracChangeset for help on using the changeset viewer.