Changeset 45074 in webkit

Timestamp:

Jun 24, 2009 1:00:10 AM (15 years ago)

Author:

eric@webkit.org

Message:

2009-06-24 Jeff Johnson <​opendarwin@lapcatsoftware.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=26638 WebKitErrors.m: _initWithPluginErrorCode: does not set localizedDescription

Add localized descriptions for plugin errors.
The localized strings already existed but were unused; now NSLocalizedDescriptionKey is added to the NSError userInfo.

• Misc/WebKitErrors.m: (-[NSError _initWithPluginErrorCode:contentURL:pluginPageURL:pluginName:MIMEType:]):

Location:

trunk/WebKit/mac

Files:

• ChangeLog (modified) (1 diff)
• Misc/WebKitErrors.m (modified) (1 diff)

trunk/WebKit/mac/ChangeLog

@@ +1 @@
+2009-06-24  Jeff Johnson  <opendarwin@lapcatsoftware.com>
+
+        Reviewed by Darin Adler.
+
+        https://bugs.webkit.org/show_bug.cgi?id=26638 WebKitErrors.m: _initWithPluginErrorCode: does not set localizedDescription
+
+        Add localized descriptions for plugin errors.
+        The localized strings already existed but were unused; now NSLocalizedDescriptionKey is added to the NSError userInfo.
+
+        * Misc/WebKitErrors.m:
+        (-[NSError _initWithPluginErrorCode:contentURL:pluginPageURL:pluginName:MIMEType:]):
+
 2009-06-23  Brady Eidson  <beidson@apple.com>
 

trunk/WebKit/mac/Misc/WebKitErrors.m

@@ -107 +107 @@
     
     NSMutableDictionary *userInfo = [[NSMutableDictionary alloc] init];
+    NSDictionary *descriptionsForWebKitErrorDomain = [descriptions objectForKey:WebKitErrorDomain];
+    NSString *localizedDescription = [descriptionsForWebKitErrorDomain objectForKey:[NSNumber numberWithInt:code]];
+    if (localizedDescription)
+        [userInfo setObject:localizedDescription forKey:NSLocalizedDescriptionKey];
     if (contentURL) {
         [userInfo setObject:contentURL forKey:@"NSErrorFailingURLKey"];