Changeset 45075 in webkit

Timestamp:

Jun 24, 2009 1:12:12 AM (15 years ago)

Author:

eric@webkit.org

Message:

2009-06-24 Siddhartha Chattopadhyay <​sidchat@google.com>

Reviewed by Eric Seidel.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=26200 which I introduced earlier. I had
the smartReplace set TRUE initially, which was wrong since the purpose of this call is
to just replace the selection, and place the caret at the end of the selection it replaced.

• editing/Editor.cpp: (WebCore::Editor::markMisspellingsAfterTypingToPosition):
• manual-tests/textarea-caret-position-after-auto-spell-correct.html: Added.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• editing/Editor.cpp (modified) (1 diff)
• manual-tests/textarea-caret-position-after-auto-spell-correct.html (added)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-06-24  Siddhartha Chattopadhyay  <sidchat@google.com>
+
+        Reviewed by Eric Seidel.
+
+        Fix for https://bugs.webkit.org/show_bug.cgi?id=26200 which I introduced earlier. I had
+        the smartReplace set TRUE initially, which was wrong since the purpose of this call is
+        to just replace the selection, and place the caret at the end of the selection it replaced.
+
+        * editing/Editor.cpp:
+        (WebCore::Editor::markMisspellingsAfterTypingToPosition):
+        * manual-tests/textarea-caret-position-after-auto-spell-correct.html: Added.
+
 2009-06-24  Kevin Watters  <kevinwatters@gmail.com>
 

trunk/WebCore/editing/Editor.cpp

@@ -2207 +2207 @@
         if (!frame()->editor()->shouldInsertText(autocorrectedString, misspellingRange.get(), EditorInsertActionTyped))
             return;
-        frame()->editor()->replaceSelectionWithText(autocorrectedString, false, true);
+        frame()->editor()->replaceSelectionWithText(autocorrectedString, false, false);
 
         // Reset the charet one character further.