Changeset 45103 in webkit

Timestamp:

Jun 24, 2009 2:10:18 PM (15 years ago)

Author:

eric@webkit.org

Message:

2009-06-24 Nicolas Weber <​thakis@chromium.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=26685
Accomodate for backwards-incompatible skia api changes.

• platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::clearRect): (WebCore::GraphicsContext::setCompositeOperation):
• platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::ImageBuffer):
• platform/graphics/skia/ImageSkia.cpp: (WebCore::paintSkBitmap): (WebCore::Image::drawPattern):
• platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::State::State): (PlatformContextSkia::setupPaintCommon): (PlatformContextSkia::setXfermodeMode): (PlatformContextSkia::applyClipFromImage):
• platform/graphics/skia/PlatformContextSkia.h:
• platform/graphics/skia/SkiaUtils.cpp: (WebCore::): (WebCore::WebCoreCompositeToSkiaComposite):
• platform/graphics/skia/SkiaUtils.h:

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/skia/GraphicsContextSkia.cpp (modified) (2 diffs)
• platform/graphics/skia/ImageBufferSkia.cpp (modified) (1 diff)
• platform/graphics/skia/ImageSkia.cpp (modified) (2 diffs)
• platform/graphics/skia/PlatformContextSkia.cpp (modified) (6 diffs)
• platform/graphics/skia/PlatformContextSkia.h (modified) (1 diff)
• platform/graphics/skia/SkiaUtils.cpp (modified) (1 diff)
• platform/graphics/skia/SkiaUtils.h (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-06-24  Nicolas Weber  <thakis@chromium.org>
+
+        Reviewed by Eric Seidel.
+
+        https://bugs.webkit.org/show_bug.cgi?id=26685
+        Accomodate for backwards-incompatible skia api changes.
+
+        * platform/graphics/skia/GraphicsContextSkia.cpp:
+        (WebCore::GraphicsContext::clearRect):
+        (WebCore::GraphicsContext::setCompositeOperation):
+        * platform/graphics/skia/ImageBufferSkia.cpp:
+        (WebCore::ImageBuffer::ImageBuffer):
+        * platform/graphics/skia/ImageSkia.cpp:
+        (WebCore::paintSkBitmap):
+        (WebCore::Image::drawPattern):
+        * platform/graphics/skia/PlatformContextSkia.cpp:
+        (PlatformContextSkia::State::State):
+        (PlatformContextSkia::setupPaintCommon):
+        (PlatformContextSkia::setXfermodeMode):
+        (PlatformContextSkia::applyClipFromImage):
+        * platform/graphics/skia/PlatformContextSkia.h:
+        * platform/graphics/skia/SkiaUtils.cpp:
+        (WebCore::):
+        (WebCore::WebCoreCompositeToSkiaComposite):
+        * platform/graphics/skia/SkiaUtils.h:
+
 2009-06-24  Jan Michael Alonzo  <jmalonzo@webkit.org>
 

trunk/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp

@@ -332 +332 @@
     SkPaint paint;
     platformContext()->setupPaintForFilling(&paint);
-    paint.setPorterDuffXfermode(SkPorterDuff::kClear_Mode);
+    paint.setXfermodeMode(SkXfermode::kClear_Mode);
     platformContext()->canvas()->drawRect(r, paint);
 }
@@ -859 +859 @@
     if (paintingDisabled())
         return;
-    platformContext()->setPorterDuffMode(WebCoreCompositeToSkiaComposite(op));
+    platformContext()->setXfermodeMode(WebCoreCompositeToSkiaComposite(op));
 }
 

trunk/WebCore/platform/graphics/skia/ImageBufferSkia.cpp

@@ -72 +72 @@
     // required, but the canvas is currently filled with the magic transparency
     // color. Can we have another way to manage this?
-    m_data.m_canvas.drawARGB(0, 0, 0, 0, SkPorterDuff::kClear_Mode);
+    m_data.m_canvas.drawARGB(0, 0, 0, 0, SkXfermode::kClear_Mode);
     success = true;
 }

trunk/WebCore/platform/graphics/skia/ImageSkia.cpp

@@ -221 +221 @@
 }
 
-static void paintSkBitmap(PlatformContextSkia* platformContext, const NativeImageSkia& bitmap, const SkIRect& srcRect, const SkRect& destRect, const SkPorterDuff::Mode& compOp)
+static void paintSkBitmap(PlatformContextSkia* platformContext, const NativeImageSkia& bitmap, const SkIRect& srcRect, const SkRect& destRect, const SkXfermode::Mode& compOp)
 {
     SkPaint paint;
-    paint.setPorterDuffXfermode(compOp);
+    paint.setXfermodeMode(compOp);
     paint.setFilterBitmap(true);
     int alpha = roundf(platformContext->getAlpha() * 256);
@@ -380 +380 @@
     SkPaint paint;
     paint.setShader(shader)->unref();
-    paint.setPorterDuffXfermode(WebCoreCompositeToSkiaComposite(compositeOp));
+    paint.setXfermodeMode(WebCoreCompositeToSkiaComposite(compositeOp));
     paint.setFilterBitmap(resampling == RESAMPLE_LINEAR);
 

trunk/WebCore/platform/graphics/skia/PlatformContextSkia.cpp

@@ -58 +58 @@
     // Common shader state.
     float m_alpha;
-    SkPorterDuff::Mode m_porterDuffMode;
+    SkXfermode::Mode m_xferMode;
     SkShader* m_gradient;
     SkShader* m_pattern;
@@ -99 +99 @@
 PlatformContextSkia::State::State()
     : m_alpha(1)
-    , m_porterDuffMode(SkPorterDuff::kSrcOver_Mode)
+    , m_xferMode(SkXfermode::kSrcOver_Mode)
     , m_gradient(0)
     , m_pattern(0)
@@ -119 +119 @@
 PlatformContextSkia::State::State(const State& other)
     : m_alpha(other.m_alpha)
-    , m_porterDuffMode(other.m_porterDuffMode)
+    , m_xferMode(other.m_xferMode)
     , m_gradient(other.m_gradient)
     , m_pattern(other.m_pattern)
@@ -300 +300 @@
 
     paint->setAntiAlias(m_state->m_useAntialiasing);
-    paint->setPorterDuffXfermode(m_state->m_porterDuffMode);
+    paint->setXfermodeMode(m_state->m_xferMode);
     paint->setLooper(m_state->m_looper);
 
@@ -383 +383 @@
 }
 
-void PlatformContextSkia::setPorterDuffMode(SkPorterDuff::Mode pdm)
-{
-    m_state->m_porterDuffMode = pdm;
+void PlatformContextSkia::setXfermodeMode(SkXfermode::Mode pdm)
+{
+    m_state->m_xferMode = pdm;
 }
 
@@ -527 +527 @@
     // only look at the alpha when compositing. I'm not 100% sure this is what WebKit expects for image clipping.
     SkPaint paint;
-    paint.setPorterDuffXfermode(SkPorterDuff::kDstIn_Mode);
+    paint.setXfermodeMode(SkXfermode::kDstIn_Mode);
     m_canvas->drawBitmap(imageBuffer, SkFloatToScalar(rect.x()), SkFloatToScalar(rect.y()), &paint);
 }

trunk/WebCore/platform/graphics/skia/PlatformContextSkia.h

@@ -116 +116 @@
     void setLineJoin(SkPaint::Join);
     void setFillRule(SkPath::FillType);
-    void setPorterDuffMode(SkPorterDuff::Mode);
+    void setXfermodeMode(SkXfermode::Mode);
     void setFillColor(SkColor);
     void setStrokeStyle(WebCore::StrokeStyle);

trunk/WebCore/platform/graphics/skia/SkiaUtils.cpp

@@ -42 +42 @@
 namespace WebCore {
 
-static const struct CompositOpToPorterDuffMode {
+static const struct CompositOpToXfermodeMode {
     uint8_t mCompositOp;
-    uint8_t mPorterDuffMode;
-} gMapCompositOpsToPorterDuffModes[] = {
-    { CompositeClear,           SkPorterDuff::kClear_Mode },
-    { CompositeCopy,            SkPorterDuff::kSrc_Mode },
-    { CompositeSourceOver,      SkPorterDuff::kSrcOver_Mode },
-    { CompositeSourceIn,        SkPorterDuff::kSrcIn_Mode },
-    { CompositeSourceOut,       SkPorterDuff::kSrcOut_Mode },
-    { CompositeSourceAtop,      SkPorterDuff::kSrcATop_Mode },
-    { CompositeDestinationOver, SkPorterDuff::kDstOver_Mode },
-    { CompositeDestinationIn,   SkPorterDuff::kDstIn_Mode },
-    { CompositeDestinationOut,  SkPorterDuff::kDstOut_Mode },
-    { CompositeDestinationAtop, SkPorterDuff::kDstATop_Mode },
-    { CompositeXOR,             SkPorterDuff::kXor_Mode },
-    { CompositePlusDarker,      SkPorterDuff::kDarken_Mode },
-    { CompositeHighlight,       SkPorterDuff::kSrcOver_Mode },  // TODO
-    { CompositePlusLighter,     SkPorterDuff::kAdd_Mode }
+    uint8_t m_xfermodeMode;
+} gMapCompositOpsToXfermodeModes[] = {
+    { CompositeClear,           SkXfermode::kClear_Mode },
+    { CompositeCopy,            SkXfermode::kSrc_Mode },
+    { CompositeSourceOver,      SkXfermode::kSrcOver_Mode },
+    { CompositeSourceIn,        SkXfermode::kSrcIn_Mode },
+    { CompositeSourceOut,       SkXfermode::kSrcOut_Mode },
+    { CompositeSourceAtop,      SkXfermode::kSrcATop_Mode },
+    { CompositeDestinationOver, SkXfermode::kDstOver_Mode },
+    { CompositeDestinationIn,   SkXfermode::kDstIn_Mode },
+    { CompositeDestinationOut,  SkXfermode::kDstOut_Mode },
+    { CompositeDestinationAtop, SkXfermode::kDstATop_Mode },
+    { CompositeXOR,             SkXfermode::kXor_Mode },
+    { CompositePlusDarker,      SkXfermode::kDarken_Mode },
+    { CompositeHighlight,       SkXfermode::kSrcOver_Mode },  // TODO
+    { CompositePlusLighter,     SkXfermode::kPlus_Mode }
 };
 
-SkPorterDuff::Mode WebCoreCompositeToSkiaComposite(CompositeOperator op)
+SkXfermode::Mode WebCoreCompositeToSkiaComposite(CompositeOperator op)
 {
-    const CompositOpToPorterDuffMode* table = gMapCompositOpsToPorterDuffModes;
+    const CompositOpToXfermodeMode* table = gMapCompositOpsToXfermodeModes;
     
-    for (unsigned i = 0; i < SK_ARRAY_COUNT(gMapCompositOpsToPorterDuffModes); i++) {
+    for (unsigned i = 0; i < SK_ARRAY_COUNT(gMapCompositOpsToXfermodeModes); i++) {
         if (table[i].mCompositOp == op)
-            return (SkPorterDuff::Mode)table[i].mPorterDuffMode;
+            return (SkXfermode::Mode)table[i].m_xfermodeMode;
     }
 
     SkDEBUGF(("GraphicsContext::setCompositeOperation uknown CompositeOperator %d\n", op));
-    return SkPorterDuff::kSrcOver_Mode; // fall-back
+    return SkXfermode::kSrcOver_Mode; // fall-back
 }
 

trunk/WebCore/platform/graphics/skia/SkiaUtils.h

@@ -37 +37 @@
 #include "GraphicsContext.h"
 #include "SkPath.h"
-#include "SkPorterDuff.h"
+#include "SkXfermode.h"
 
 class SkCanvas;
@@ -44 +44 @@
 namespace WebCore {
 
-SkPorterDuff::Mode WebCoreCompositeToSkiaComposite(CompositeOperator);
+SkXfermode::Mode WebCoreCompositeToSkiaComposite(CompositeOperator);
 
 // move this guy into SkColor.h