Changeset 45152 in webkit

Timestamp:

Jun 25, 2009 12:42:33 AM (15 years ago)

Author:

eric@webkit.org

Message:

2009-06-25 Eric Seidel <​eric@webkit.org>

Reviewed by Tor Arne Vestbø.

Remove use of os.system to fix reviewers with unicode chars in their names
​https://bugs.webkit.org/show_bug.cgi?id=26713

Also change to latin1 encoding of ø to make python happy.

• Scripts/modules/bugzilla.py:
• Scripts/modules/scm.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/modules/bugzilla.py (modified) (1 diff)
• Scripts/modules/scm.py (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2009-06-25  Eric Seidel  <eric@webkit.org>
+
+        Reviewed by Tor Arne Vestbø.
+
+        Remove use of os.system to fix reviewers with unicode chars in their names
+        https://bugs.webkit.org/show_bug.cgi?id=26713
+
+        Also change to latin1 encoding of ø to make python happy.
+
+        * Scripts/modules/bugzilla.py:
+        * Scripts/modules/scm.py:
+
 2009-06-25  Eric Seidel  <eric@webkit.org>
 

trunk/WebKitTools/Scripts/modules/bugzilla.py

@@ -103 +103 @@
         "timothy" : "Timothy Hatcher",
         "treat" : "Adam Treat",
-        "vestbo" : u'Tor Arne Vestb\xc3',
+        "vestbo" : u'Tor Arne Vestb\xf8',
         "xan.lopez" : "Xan Lopez",
         "zecke" : "Holger Freyther",

trunk/WebKitTools/Scripts/modules/scm.py

@@ -92 +92 @@
         # It's possible that the patch was not made from the root directory.
         # We should detect and handle that case.
-        return_code = os.system('curl %s | svn-apply --reviewer "%s"' % (patch['url'], patch['reviewer']))
+        curl_process = subprocess.Popen(['curl', patch['url']], stdout=subprocess.PIPE)
+        patch_apply_process = subprocess.Popen(['svn-apply', '--reviewer', patch['reviewer']], stdin=curl_process.stdout)
+
+        return_code = patch_apply_process.wait()
         if return_code:
             raise ScriptError("Patch " + patch['url'] + " failed to download and apply.")