Changeset 45403 in webkit

Timestamp:

Jun 30, 2009 3:06:55 PM (15 years ago)

Author:

sfalken@apple.com

Message:

​https://bugs.webkit.org/show_bug.cgi?id=26860

Reviewed by Sam Weinig.

Blacklist Yahoo Application State plug-in for versions prior to 1.0.0.6.
Earlier versions cause corruption crashes.

• plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::isPluginBlacklisted):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• plugins/win/PluginPackageWin.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-06-30  Steve Falkenburg  <sfalken@apple.com>
+
+        https://bugs.webkit.org/show_bug.cgi?id=26860
+
+        Reviewed by Sam Weinig.
+
+        Blacklist Yahoo Application State plug-in for versions prior to 1.0.0.6.
+        Earlier versions cause corruption crashes.
+
+        * plugins/win/PluginPackageWin.cpp:
+        (WebCore::PluginPackage::isPluginBlacklisted):
+
 2009-06-30  Dean Jackson  <dino@apple.com>
 

trunk/WebCore/plugins/win/PluginPackageWin.cpp

@@ -82 +82 @@
         if (compareFileVersion(slPluginMinRequired) < 0)
             return true;
-    } else if (fileName() == "npmozax.dll")
+    } else if (fileName() == "npmozax.dll") {
         // Bug 15217: Mozilla ActiveX control complains about missing xpcom_core.dll
         return true;
+    } else if (name() == "Yahoo Application State Plugin") {
+        // https://bugs.webkit.org/show_bug.cgi?id=26860
+        // Bug in Yahoo Application State plug-in earlier than 1.0.0.6 leads to heap corruption. 
+        static const PlatformModuleVersion yahooAppStatePluginMinRequired(0x00000006, 0x00010000);
+        if (compareFileVersion(yahooAppStatePluginMinRequired) < 0)
+            return true;
+    }
 
     return false;