Changeset 45535 in webkit


Ignore:
Timestamp:
Jul 3, 2009 7:08:34 AM (15 years ago)
Author:
xan@webkit.org
Message:

2009-07-02 Xan Lopez <​xlopez@igalia.com>

Reviewed by Jan Alonzo.

​https://bugs.webkit.org/show_bug.cgi?id=26814
[Gtk] Caret-moved events are not issued for the correct offset
when text is selected forward

Report the caret offset from the end of the selection, otherwise
we'll report the same offset when moving the caret while
modififying the selection (eg, with Shift + Right).

  • editing/gtk/SelectionControllerGtk.cpp: (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
Location:
trunk/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r45534 r45535  
     12009-07-02  Xan Lopez  <xlopez@igalia.com>
     2
     3        Reviewed by Jan Alonzo.
     4
     5        https://bugs.webkit.org/show_bug.cgi?id=26814
     6        [Gtk] Caret-moved events are not issued for the correct offset
     7        when text is selected forward
     8
     9        Report the caret offset from the end of the selection, otherwise
     10        we'll report the same offset when moving the caret while
     11        modififying the selection (eg, with Shift + Right).
     12
     13        * editing/gtk/SelectionControllerGtk.cpp:
     14        (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
     15
    1162009-07-02  Xan Lopez  <xlopez@igalia.com>
    217

  • trunk/WebCore/editing/gtk/SelectionControllerGtk.cpp

    r45534 r45535  
    3535        AtkObject* wrapper = accessibilityObject->wrapper();
    3636        if (ATK_IS_TEXT(wrapper)) {
    37             g_signal_emit_by_name(wrapper, "text-caret-moved", m_sel.start().computeOffsetInContainerNode());
     37            g_signal_emit_by_name(wrapper, "text-caret-moved", m_sel.end().computeOffsetInContainerNode());
    3838
    3939            if (m_sel.isRange())
Note: See TracChangeset for help on using the changeset viewer.