Changeset 45537 in webkit

Timestamp:

Jul 3, 2009 1:54:24 PM (15 years ago)

Author:

Simon Fraser

Message:

2009-07-03 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

Background audio stops playing when JS GC runs
​https://bugs.webkit.org/show_bug.cgi?id=26956

Ensure we keep the Audio object around while it is playing, so that it
doesn't get collected.

Not testable because there's no way to know whether the audio keeps
playing without holding a reference to it.

• bindings/js/JSDOMBinding.cpp: (WebCore::isObservableThroughDOM):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/js/JSDOMBinding.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-07-03  Simon Fraser  <simon.fraser@apple.com>
+
+        Reviewed by Sam Weinig.
+
+        Background audio stops playing when JS GC runs
+        https://bugs.webkit.org/show_bug.cgi?id=26956
+        
+        Ensure we keep the Audio object around while it is playing, so that it
+        doesn't get collected.
+        
+        Not testable because there's no way to know whether the audio keeps
+        playing without holding a reference to it.
+
+        * bindings/js/JSDOMBinding.cpp:
+        (WebCore::isObservableThroughDOM):
+
 2009-07-02  Xan Lopez  <xlopez@igalia.com>
 

trunk/WebCore/bindings/js/JSDOMBinding.cpp

@@ -33 +33 @@
 #include "ExceptionCode.h"
 #include "Frame.h"
+#include "HTMLAudioElement.h"
 #include "HTMLImageElement.h"
 #include "HTMLScriptElement.h"
@@ -289 +290 @@
         if (node->hasTagName(scriptTag) && !static_cast<HTMLScriptElement*>(node)->haveFiredLoadEvent())
             return true;
+#if ENABLE(VIDEO)
+        if (node->hasTagName(audioTag) && !static_cast<HTMLAudioElement*>(node)->paused())
+            return true;
+#endif
     }