Changeset 45739 in webkit
- Timestamp:
- Jul 10, 2009 5:57:19 PM (15 years ago)
- Location:
- trunk
- Files:
-
- 5 added
- 17 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r45727 r45739 1 2009-07-10 Michelangelo De Simone <micdesim@gmail.com> 2 3 Reviewed by Adele Peterson. 4 5 https://bugs.webkit.org/show_bug.cgi?id=19562 6 Minimal test case for ValidityState; more tests are going to be added 7 along with specific validation routines. 8 9 * fast/forms/ValidityState-001-expected.txt: Added. 10 * fast/forms/ValidityState-001.html: Added. 11 1 12 2009-07-10 Simon Hausmann <hausmann@webkit.org> 2 13 -
trunk/WebCore/ChangeLog
r45734 r45739 1 2009-07-10 Michelangelo De Simone <micdesim@gmail.com> 2 3 Reviewed by Adele Peterson. 4 5 https://bugs.webkit.org/show_bug.cgi?id=19562 6 Added build stuff and stub for the ValidityState class, part of HTML5 7 section Forms: 8 http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#validitystate 9 10 Test: fast/forms/ValidityState-001.html 11 12 * DerivedSources.cpp: Fix aimed to include ValidityState files 13 * DerivedSources.make: ditto 14 * GNUmakefile.am: ditto 15 * WebCore.gypi: ditto 16 * WebCore.pro: ditto 17 * WebCore.vcproj/WebCore.vcproj: ditto 18 * WebCore.xcodeproj/project.pbxproj: ditto 19 * WebCoreSources.bkl: ditto 20 * html/HTMLButtonElement.idl: "validity" attribute 21 * html/HTMLFieldSetElement.idl: ditto 22 * html/HTMLFormControlElement.cpp: object getter 23 (WebCore::HTMLFormControlElement::validity): 24 * html/HTMLFormControlElement.h: ditto 25 * html/HTMLInputElement.idl: "validity" attribute 26 * html/HTMLSelectElement.idl: ditto 27 * html/HTMLTextAreaElement.idl: ditto 28 * html/ValidityState.cpp: Added. 29 (WebCore::ValidityState::ValidityState): 30 (WebCore::ValidityState::valid): validation flag 31 * html/ValidityState.h: Added. 32 (WebCore::ValidityState::create): creation routine 33 (WebCore::ValidityState::control): ValidityState's parent getter 34 (WebCore::ValidityState::valueMissing): validation flag 35 (WebCore::ValidityState::typeMismatch): ditto 36 (WebCore::ValidityState::patternMismatch): ditto 37 (WebCore::ValidityState::tooLong): ditto 38 (WebCore::ValidityState::rangeUnderflow): ditto 39 (WebCore::ValidityState::rangeOverflow): ditto 40 (WebCore::ValidityState::stepMismatch): ditto 41 (WebCore::ValidityState::customError): ditto 42 * html/ValidityState.idl: Added. 43 1 44 2009-07-10 Brady Eidson <beidson@apple.com> 2 45 -
trunk/WebCore/DerivedSources.cpp
r45093 r45739 318 318 #include "JSTreeWalker.cpp" 319 319 #include "JSUIEvent.cpp" 320 #include "JSValidityState.cpp" 320 321 #include "JSVoidCallback.cpp" 321 322 #include "JSWebKitAnimationEvent.cpp" -
trunk/WebCore/DerivedSources.make
r45419 r45739 361 361 TreeWalker \ 362 362 UIEvent \ 363 ValidityState \ 363 364 VoidCallback \ 364 365 WebKitAnimationEvent \ -
trunk/WebCore/GNUmakefile.am
r45697 r45739 229 229 WebCore/html/ImageData.idl \ 230 230 WebCore/html/TextMetrics.idl \ 231 WebCore/html/ValidityState.idl \ 231 232 WebCore/html/VoidCallback.idl \ 232 233 WebCore/inspector/JavaScriptCallFrame.idl \ … … 1079 1080 WebCore/html/PreloadScanner.h \ 1080 1081 WebCore/html/TextMetrics.h \ 1082 WebCore/html/ValidityState.cpp \ 1083 WebCore/html/ValidityState.h \ 1081 1084 WebCore/html/VoidCallback.h \ 1082 1085 WebCore/icu/unicode/parseerr.h \ -
trunk/WebCore/WebCore.gypi
r45683 r45739 153 153 'html/TextMetrics.idl', 154 154 'html/TimeRanges.idl', 155 'html/ValidityState.idl', 155 156 'html/VoidCallback.idl', 156 157 'inspector/InspectorController.idl', … … 1339 1340 'html/TimeRanges.cpp', 1340 1341 'html/TimeRanges.h', 1342 'html/ValidityState.cpp', 1343 'html/ValidityState.h', 1341 1344 'html/VoidCallback.h', 1342 1345 'inspector/InspectorClient.h', -
trunk/WebCore/WebCore.pro
r45704 r45739 412 412 html/MediaError.idl \ 413 413 html/TextMetrics.idl \ 414 html/ValidityState.idl \ 414 415 html/VoidCallback.idl \ 415 416 inspector/InspectorController.idl \ … … 842 843 html/ImageData.cpp \ 843 844 html/PreloadScanner.cpp \ 845 html/ValidityState.cpp \ 844 846 inspector/ConsoleMessage.cpp \ 845 847 inspector/InspectorDatabaseResource.cpp \ -
trunk/WebCore/WebCore.vcproj/WebCore.vcproj
r45651 r45739 14776 14776 <File 14777 14777 RelativePath="$(WebKitOutputDir)\obj\$(ProjectName)\DerivedSources\JSUIEvent.h" 14778 > 14779 </File> 14780 <File 14781 RelativePath="$(WebKitOutputDir)\obj\$(ProjectName)\DerivedSources\JSValidityState.cpp" 14782 > 14783 <FileConfiguration 14784 Name="Debug|Win32" 14785 ExcludedFromBuild="true" 14786 > 14787 <Tool 14788 Name="VCCLCompilerTool" 14789 /> 14790 </FileConfiguration> 14791 <FileConfiguration 14792 Name="Release|Win32" 14793 ExcludedFromBuild="true" 14794 > 14795 <Tool 14796 Name="VCCLCompilerTool" 14797 /> 14798 </FileConfiguration> 14799 <FileConfiguration 14800 Name="Debug_Internal|Win32" 14801 ExcludedFromBuild="true" 14802 > 14803 <Tool 14804 Name="VCCLCompilerTool" 14805 /> 14806 </FileConfiguration> 14807 <FileConfiguration 14808 Name="Debug_Cairo|Win32" 14809 ExcludedFromBuild="true" 14810 > 14811 <Tool 14812 Name="VCCLCompilerTool" 14813 /> 14814 </FileConfiguration> 14815 <FileConfiguration 14816 Name="Release_Cairo|Win32" 14817 ExcludedFromBuild="true" 14818 > 14819 <Tool 14820 Name="VCCLCompilerTool" 14821 /> 14822 </FileConfiguration> 14823 </File> 14824 <File 14825 RelativePath="$(WebKitOutputDir)\obj\$(ProjectName)\DerivedSources\JSValidityState.h" 14778 14826 > 14779 14827 </File> … … 27928 27976 </File> 27929 27977 <File 27978 RelativePath="..\html\ValidityState.cpp" 27979 > 27980 </File> 27981 <File 27982 RelativePath="..\html\ValidityState.h" 27983 > 27984 </File> 27985 <File 27930 27986 RelativePath="..\html\VoidCallback.h" 27931 27987 > -
trunk/WebCore/WebCore.xcodeproj/project.pbxproj
r45719 r45739 205 205 14FFE31D0AE1963300136BF5 /* HTMLFrameElementBase.h in Headers */ = {isa = PBXBuildFile; fileRef = 14FFE31B0AE1963300136BF5 /* HTMLFrameElementBase.h */; settings = {ATTRIBUTES = (Private, ); }; }; 206 206 14FFE31E0AE1963300136BF5 /* HTMLFrameElementBase.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 14FFE31C0AE1963300136BF5 /* HTMLFrameElementBase.cpp */; }; 207 1528C9CA10076C47006560E0 /* ValidityState.idl in Resources */ = {isa = PBXBuildFile; fileRef = 1528C9C710076C47006560E0 /* ValidityState.idl */; }; 208 1528C9CB10076C47006560E0 /* ValidityState.h in Headers */ = {isa = PBXBuildFile; fileRef = 1528C9C810076C47006560E0 /* ValidityState.h */; }; 209 1528C9CC10076C47006560E0 /* ValidityState.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1528C9C910076C47006560E0 /* ValidityState.cpp */; }; 210 1528C9CF10076D15006560E0 /* JSValidityState.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1528C9CD10076D15006560E0 /* JSValidityState.cpp */; }; 211 1528C9D010076D15006560E0 /* JSValidityState.h in Headers */ = {isa = PBXBuildFile; fileRef = 1528C9CE10076D15006560E0 /* JSValidityState.h */; }; 212 1528C9D510076D4A006560E0 /* DOMValidityState.h in Headers */ = {isa = PBXBuildFile; fileRef = 1528C9D310076D4A006560E0 /* DOMValidityState.h */; }; 213 1528C9D610076D4A006560E0 /* DOMValidityState.mm in Sources */ = {isa = PBXBuildFile; fileRef = 1528C9D410076D4A006560E0 /* DOMValidityState.mm */; }; 214 1528C9D810076D6D006560E0 /* DOMValidityStateInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = 1528C9D710076D6D006560E0 /* DOMValidityStateInternal.h */; }; 215 15A92E4E1007768800BC7AA5 /* DOMValidityState.h in Copy Generated Headers */ = {isa = PBXBuildFile; fileRef = 1528C9D310076D4A006560E0 /* DOMValidityState.h */; }; 216 15A92E4F1007769000BC7AA5 /* DOMValidityStateInternal.h in Copy Generated Headers */ = {isa = PBXBuildFile; fileRef = 1528C9D710076D6D006560E0 /* DOMValidityStateInternal.h */; }; 207 217 185BCF280F3279CE000EA262 /* ThreadTimers.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 185BCF260F3279CE000EA262 /* ThreadTimers.cpp */; }; 208 218 185BCF290F3279CE000EA262 /* ThreadTimers.h in Headers */ = {isa = PBXBuildFile; fileRef = 185BCF270F3279CE000EA262 /* ThreadTimers.h */; }; … … 4901 4911 85526D050AB0B979000302EA /* DOMTreeWalker.h in Copy Generated Headers */, 4902 4912 85C7F4D00AAF83F6004014DD /* DOMUIEvent.h in Copy Generated Headers */, 4913 15A92E4E1007768800BC7AA5 /* DOMValidityState.h in Copy Generated Headers */, 4914 15A92E4F1007769000BC7AA5 /* DOMValidityStateInternal.h in Copy Generated Headers */, 4903 4915 85DF34600AAFC2D400E59AE3 /* DOMWheelEvent.h in Copy Generated Headers */, 4904 4916 85E9E0A80AB3A11900069CD0 /* DOMXPathExpression.h in Copy Generated Headers */, … … 5100 5112 14FFE31B0AE1963300136BF5 /* HTMLFrameElementBase.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = HTMLFrameElementBase.h; sourceTree = "<group>"; }; 5101 5113 14FFE31C0AE1963300136BF5 /* HTMLFrameElementBase.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = HTMLFrameElementBase.cpp; sourceTree = "<group>"; }; 5114 1528C9C710076C47006560E0 /* ValidityState.idl */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = ValidityState.idl; sourceTree = "<group>"; }; 5115 1528C9C810076C47006560E0 /* ValidityState.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ValidityState.h; sourceTree = "<group>"; }; 5116 1528C9C910076C47006560E0 /* ValidityState.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ValidityState.cpp; sourceTree = "<group>"; }; 5117 1528C9CD10076D15006560E0 /* JSValidityState.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSValidityState.cpp; sourceTree = "<group>"; }; 5118 1528C9CE10076D15006560E0 /* JSValidityState.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSValidityState.h; sourceTree = "<group>"; }; 5119 1528C9D310076D4A006560E0 /* DOMValidityState.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DOMValidityState.h; sourceTree = "<group>"; }; 5120 1528C9D410076D4A006560E0 /* DOMValidityState.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = DOMValidityState.mm; sourceTree = "<group>"; }; 5121 1528C9D710076D6D006560E0 /* DOMValidityStateInternal.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DOMValidityStateInternal.h; sourceTree = "<group>"; }; 5102 5122 185BCF260F3279CE000EA262 /* ThreadTimers.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ThreadTimers.cpp; sourceTree = "<group>"; }; 5103 5123 185BCF270F3279CE000EA262 /* ThreadTimers.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ThreadTimers.h; sourceTree = "<group>"; }; … … 11232 11252 85BA4D090AA688680088052D /* DOMHTMLUListElement.h */, 11233 11253 85BA4D0A0AA688680088052D /* DOMHTMLUListElement.mm */, 11254 1528C9D310076D4A006560E0 /* DOMValidityState.h */, 11255 1528C9D410076D4A006560E0 /* DOMValidityState.mm */, 11234 11256 ); 11235 11257 name = HTML; … … 11470 11492 850B41C10AD9E7E700A6ED4F /* DOMTreeWalkerInternal.h */, 11471 11493 85989DC90ACC8BBD00A0BC51 /* DOMUIEventInternal.h */, 11494 1528C9D710076D6D006560E0 /* DOMValidityStateInternal.h */, 11472 11495 85989DCA0ACC8BBD00A0BC51 /* DOMWheelEventInternal.h */, 11473 11496 85E7118B0AC5D5350053270F /* DOMXPathExpressionInternal.h */, … … 11920 11943 E446139E0CD6331000FADA75 /* TimeRanges.h */, 11921 11944 E446139F0CD6331000FADA75 /* TimeRanges.idl */, 11945 1528C9C910076C47006560E0 /* ValidityState.cpp */, 11946 1528C9C810076C47006560E0 /* ValidityState.h */, 11947 1528C9C710076C47006560E0 /* ValidityState.idl */, 11922 11948 E44613B40CD6344E00FADA75 /* VoidCallback.h */, 11923 11949 E44613A00CD6331000FADA75 /* VoidCallback.idl */, … … 12111 12137 E44614120CD6826900FADA75 /* JSTimeRanges.cpp */, 12112 12138 E44614130CD6826900FADA75 /* JSTimeRanges.h */, 12139 1528C9CD10076D15006560E0 /* JSValidityState.cpp */, 12140 1528C9CE10076D15006560E0 /* JSValidityState.h */, 12113 12141 BC8243270D0CE8A200460C8F /* JSVoidCallback.cpp */, 12114 12142 BC8243280D0CE8A200460C8F /* JSVoidCallback.h */, … … 15593 15621 85C7F4910AAF79DC004014DD /* DOMUIEvent.h in Headers */, 15594 15622 85989DD00ACC8BBD00A0BC51 /* DOMUIEventInternal.h in Headers */, 15623 1528C9D510076D4A006560E0 /* DOMValidityState.h in Headers */, 15624 1528C9D810076D6D006560E0 /* DOMValidityStateInternal.h in Headers */, 15595 15625 BC1A37C0097C715F0019F3D8 /* DOMViews.h in Headers */, 15596 15626 31C0FF490E4CEFDD007D6FE5 /* DOMWebKitAnimationEvent.h in Headers */, … … 16191 16221 1A750D5D0A90DEE1000FF215 /* JSTreeWalker.h in Headers */, 16192 16222 A86629CF09DA2B47009633A5 /* JSUIEvent.h in Headers */, 16223 1528C9D010076D15006560E0 /* JSValidityState.h in Headers */, 16193 16224 BC82432C0D0CE8A200460C8F /* JSVoidCallback.h in Headers */, 16194 16225 31C0FF3E0E4CEFAC007D6FE5 /* JSWebKitAnimationEvent.h in Headers */, … … 16817 16848 656581B209D14EE6000E61D7 /* UserAgentStyleSheets.h in Headers */, 16818 16849 7284ADDE0E6FEB31002EEFBD /* UserStyleSheetLoader.h in Headers */, 16850 1528C9CB10076C47006560E0 /* ValidityState.h in Headers */, 16819 16851 93309E1E099E64920056E581 /* visible_units.h in Headers */, 16820 16852 93309E20099E64920056E581 /* VisiblePosition.h in Headers */, … … 17038 17070 85136CA60AED665900F90A3D /* southWestResizeCursor.png in Resources */, 17039 17071 ED048ABC0833F132006E1E67 /* textAreaResizeCorner.tiff in Resources */, 17072 1528C9CA10076C47006560E0 /* ValidityState.idl in Resources */, 17040 17073 46D4F24B0AF97E810035385A /* verticalTextCursor.png in Resources */, 17041 17074 85136CA70AED665900F90A3D /* waitCursor.png in Resources */, … … 17636 17669 85C7F4920AAF79DC004014DD /* DOMUIEvent.mm in Sources */, 17637 17670 BC1A37BF097C715F0019F3D8 /* DOMUtility.mm in Sources */, 17671 1528C9D610076D4A006560E0 /* DOMValidityState.mm in Sources */, 17638 17672 31C0FF4A0E4CEFDD007D6FE5 /* DOMWebKitAnimationEvent.mm in Sources */, 17639 17673 316FE07E0E6CCC2800BF6088 /* DOMWebKitCSSKeyframeRule.mm in Sources */, … … 18276 18310 516BB7940CE91E6800512F79 /* JSTreeWalkerCustom.cpp in Sources */, 18277 18311 A86629D009DA2B48009633A5 /* JSUIEvent.cpp in Sources */, 18312 1528C9CF10076D15006560E0 /* JSValidityState.cpp in Sources */, 18278 18313 BC82432B0D0CE8A200460C8F /* JSVoidCallback.cpp in Sources */, 18279 18314 31C0FF3D0E4CEFAC007D6FE5 /* JSWebKitAnimationEvent.cpp in Sources */, … … 18846 18881 65DF326109D1E199000BE325 /* UserAgentStyleSheetsData.cpp in Sources */, 18847 18882 7284ADDD0E6FEB31002EEFBD /* UserStyleSheetLoader.cpp in Sources */, 18883 1528C9CC10076C47006560E0 /* ValidityState.cpp in Sources */, 18848 18884 93309E1D099E64920056E581 /* visible_units.cpp in Sources */, 18849 18885 93309E1F099E64920056E581 /* VisiblePosition.cpp in Sources */, -
trunk/WebCore/WebCoreSources.bkl
r45651 r45739 396 396 DerivedSources/WebCore/JSTreeWalker.cpp 397 397 DerivedSources/WebCore/JSUIEvent.cpp 398 DerivedSources/WebCore/JSValidityState.cpp 398 399 DerivedSources/WebCore/JSWebKitAnimationEvent.cpp 399 400 DerivedSources/WebCore/JSWebKitCSSKeyframeRule.cpp … … 654 655 html/ImageData.cpp 655 656 html/PreloadScanner.cpp 657 html/ValidityState.cpp 656 658 </set> 657 659 -
trunk/WebCore/html/HTMLButtonElement.idl
r35381 r45739 27 27 ] HTMLButtonElement : HTMLElement { 28 28 readonly attribute HTMLFormElement form; 29 #if !defined(LANGUAGE_COM) || !LANGUAGE_COM 30 readonly attribute ValidityState validity; 31 #endif 29 32 attribute [ConvertNullToNullString] DOMString accessKey; 30 33 attribute boolean disabled; -
trunk/WebCore/html/HTMLFieldSetElement.idl
r35381 r45739 26 26 ] HTMLFieldSetElement : HTMLElement { 27 27 readonly attribute HTMLFormElement form; 28 #if !defined(LANGUAGE_COM) || !LANGUAGE_COM 29 readonly attribute ValidityState validity; 30 #endif 28 31 readonly attribute boolean willValidate; 29 32 }; -
trunk/WebCore/html/HTMLFormControlElement.cpp
r45723 r45739 40 40 #include "RenderBox.h" 41 41 #include "RenderTheme.h" 42 #include "ValidityState.h" 42 43 43 44 namespace WebCore { … … 62 63 if (m_form) 63 64 m_form->removeFormElement(this); 65 } 66 67 ValidityState* HTMLFormControlElement::validity() 68 { 69 if (!m_validityState) 70 m_validityState = ValidityState::create(this); 71 72 return m_validityState.get(); 64 73 } 65 74 -
trunk/WebCore/html/HTMLFormControlElement.h
r45723 r45739 31 31 class FormDataList; 32 32 class HTMLFormElement; 33 class ValidityState; 33 34 34 35 class HTMLFormControlElement : public HTMLElement { … … 41 42 42 43 HTMLFormElement* form() const { return m_form; } 44 virtual ValidityState* validity(); 43 45 44 46 virtual bool isTextFormControl() const { return false; } … … 111 113 112 114 HTMLFormElement* m_form; 115 RefPtr<ValidityState> m_validityState; 113 116 bool m_disabled; 114 117 bool m_readOnly; -
trunk/WebCore/html/HTMLInputElement.idl
r43784 r45739 29 29 attribute boolean defaultChecked; 30 30 readonly attribute HTMLFormElement form; 31 #if !defined(LANGUAGE_COM) || !LANGUAGE_COM 32 readonly attribute ValidityState validity; 33 #endif 31 34 attribute [ConvertNullToNullString] DOMString accept; 32 35 attribute [ConvertNullToNullString] DOMString accessKey; … … 70 73 #endif 71 74 72 #if !defined(LANGUAGE_COM) 75 #if !defined(LANGUAGE_COM) || !LANGUAGE_COM 73 76 readonly attribute FileList files; 74 77 #endif -
trunk/WebCore/html/HTMLSelectElement.idl
r43528 r45739 42 42 43 43 readonly attribute HTMLFormElement form; 44 #if !defined(LANGUAGE_COM) || !LANGUAGE_COM 45 readonly attribute ValidityState validity; 46 #endif 44 47 readonly attribute boolean willValidate; 45 48 -
trunk/WebCore/html/HTMLTextAreaElement.idl
r35381 r45739 28 28 attribute [ConvertNullToNullString] DOMString defaultValue; 29 29 readonly attribute HTMLFormElement form; 30 #if !defined(LANGUAGE_COM) || !LANGUAGE_COM 31 readonly attribute ValidityState validity; 32 #endif 30 33 attribute [ConvertNullToNullString] DOMString accessKey; 31 34 attribute long cols;
Note: See TracChangeset
for help on using the changeset viewer.