Changeset 46125 in webkit

Timestamp:

Jul 20, 2009 6:47:24 AM (15 years ago)

Author:

xan@webkit.org

Message:

2009-07-20 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=27097
[Gtk] Segfault when examining an object of ROLE_TABLE via at-spi

Check that an object is a RenderObject before trying to access its
renderer and related node.

• accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_role):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• accessibility/gtk/AccessibilityObjectWrapperAtk.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-07-20  Xan Lopez  <xlopez@igalia.com>
+
+        Reviewed by Gustavo Noronha.
+
+        https://bugs.webkit.org/show_bug.cgi?id=27097
+        [Gtk] Segfault when examining an object of ROLE_TABLE via at-spi
+
+        Check that an object is a RenderObject before trying to access its
+        renderer and related node.
+
+        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
+        (webkit_accessible_get_role):
+
 2009-07-20  Balazs Kelemen  <kelemen.balazs.3@stud.u-szeged.hu>
 

trunk/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp

@@ -278 +278 @@
 
     // WebCore does not know about paragraph role
-    Node* node = static_cast<AccessibilityRenderObject*>(AXObject)->renderer()->node();
-    if (node && node->hasTagName(HTMLNames::pTag))
-        return ATK_ROLE_PARAGRAPH;
+    if (AXObject->isAccessibilityRenderObject()) {
+        Node* node = static_cast<AccessibilityRenderObject*>(AXObject)->renderer()->node();
+        if (node && node->hasTagName(HTMLNames::pTag))
+            return ATK_ROLE_PARAGRAPH;
+    }
 
     // Note: Why doesn't WebCore have a password field for this