Changeset 46229 in webkit

Timestamp:

Jul 22, 2009 11:55:05 AM (15 years ago)

Author:

levin@chromium.org

Message:

2009-07-22 Paul Godavari <​paul@chromium.org>

Reviewed by Darin Fisher.

Chromium has a build break after removal of JSRGBColor bindings
​https://bugs.webkit.org/show_bug.cgi?id=27548

Fix a build break in Chromium V8 after the JSRGBColor bindings change:
​https://bugs.webkit.org/show_bug.cgi?id=27242

• bindings/scripts/CodeGeneratorV8.pm:

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/scripts/CodeGeneratorV8.pm (modified) (5 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-07-22  Paul Godavari  <paul@chromium.org>
+
+        Reviewed by Darin Fisher.
+
+        Chromium has a build break after removal of JSRGBColor bindings
+        https://bugs.webkit.org/show_bug.cgi?id=27548
+
+        Fix a build break in Chromium V8 after the JSRGBColor bindings change:
+        https://bugs.webkit.org/show_bug.cgi?id=27242
+
+        * bindings/scripts/CodeGeneratorV8.pm:
+
 2009-07-22  Adam Langley  <agl@google.com>
 

trunk/WebCore/bindings/scripts/CodeGeneratorV8.pm

@@ -114 +114 @@
 {
     my $type = shift;
-    return 0 if $type eq "RGBColor";
     return $codeGenerator->IsPodType($type);
 }
@@ -597 +596 @@
 
         push(@implContentDecls, "    void* wrapper = $wrapper;\n");
-    } elsif ($nativeType ne "RGBColor") {
+    } else {
         push(@implContentDecls, "    $nativeType v = ");
 
@@ -610 +609 @@
             $result = "WTF::getPtr(" . $result . ")";
         }
-    } else {
-        # Special case: RGBColor is noncopyable
-        $result = $getterString;
-    }
-
+    }
 
     if (IsSVGTypeNeedingContextParameter($attrType) && !$skipContext) {
@@ -1700 +1695 @@
     return "DOMTimeStamp" if $type eq "DOMTimeStamp";
     return "unsigned" if $type eq "unsigned int";
-    return "unsigned" if $type eq "RGBColor";
     return "Node*" if $type eq "EventTarget" and $isParameter;
 
@@ -2040 +2034 @@
     }
 
-    if ($type eq "RGBColor") {
-        my $construct = "RefPtr<RGBColor> rgbcolor = RGBColor::create($value);\n";
-        my $convert = "V8DOMWrapper::convertToV8Object(V8ClassIndex::RGBCOLOR, WTF::getPtr(rgbcolor))";
-        return $construct . $indent . "return " . $convert;
-    }
-
     if ($type eq "WorkerContext" or $type eq "WorkerLocation" or $type eq "WorkerNavigator") {
         $implIncludes{"WorkerContextExecutionProxy.h"} = 1;