Changeset 46370 in webkit
- Timestamp:
- Jul 24, 2009 12:28:00 PM (15 years ago)
- Location:
- trunk/WebCore
- Files:
-
- 9 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/WebCore/ChangeLog
r46369 r46370 97 97 (WebCore::WorkerThread::workerThread): 98 98 Creates a DedicatedWorkerContext when the thread starts up. 99 100 2009-07-24 Eric Seidel <eric@webkit.org> 101 102 Reviewed by Adam Barth. 103 104 Move more callers to using 3 argument toJS 105 https://bugs.webkit.org/show_bug.cgi?id=27661 106 107 No functional changes, thus no tests. 108 These are all the places where we can't yet pass the 109 correct globalObject because we don't have or don't know the right one. 110 111 * bindings/js/JSCustomPositionCallback.cpp: 112 (WebCore::JSCustomPositionCallback::handleEvent): 113 * bindings/js/JSCustomPositionErrorCallback.cpp: 114 (WebCore::JSCustomPositionErrorCallback::handleEvent): 115 * bindings/js/JSCustomSQLStatementCallback.cpp: 116 (WebCore::JSCustomSQLStatementCallback::handleEvent): 117 * bindings/js/JSCustomSQLStatementErrorCallback.cpp: 118 (WebCore::JSCustomSQLStatementErrorCallback::handleEvent): 119 * bindings/js/JSCustomSQLTransactionCallback.cpp: 120 (WebCore::JSCustomSQLTransactionCallback::handleEvent): 121 * bindings/js/JSCustomSQLTransactionErrorCallback.cpp: 122 (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent): 123 * bindings/js/JSNodeFilterCondition.cpp: 124 (WebCore::JSNodeFilterCondition::acceptNode): 99 125 100 126 2009-07-24 Eric Seidel <eric@webkit.org> -
trunk/WebCore/bindings/js/JSCustomPositionCallback.cpp
r44094 r46370 49 49 if (!m_frame->script()->isEnabled()) 50 50 return; 51 51 52 // FIXME: This is likely the wrong globalObject (for prototype chains at least) 52 53 JSGlobalObject* globalObject = m_frame->script()->globalObject(); 53 54 ExecState* exec = globalObject->globalExec(); … … 68 69 69 70 RefPtr<JSCustomPositionCallback> protect(this); 70 71 71 72 MarkedArgumentBuffer args; 72 args.append(toJS(exec, geoposition));73 73 args.append(toJS(exec, deprecatedGlobalObjectForPrototype(exec), geoposition)); 74 74 75 globalObject->globalData()->timeoutChecker.start(); 75 76 call(exec, function, callType, callData, m_callback, args); -
trunk/WebCore/bindings/js/JSCustomPositionErrorCallback.cpp
r44094 r46370 49 49 if (!m_frame->script()->isEnabled()) 50 50 return; 51 51 52 // FIXME: This is likely the wrong globalObject (for prototype chains at least) 52 53 JSGlobalObject* globalObject = m_frame->script()->globalObject(); 53 54 ExecState* exec = globalObject->globalExec(); … … 70 71 71 72 MarkedArgumentBuffer args; 72 args.append(toJS(exec, positionError));73 args.append(toJS(exec, deprecatedGlobalObjectForPrototype(exec), positionError)); 73 74 74 75 globalObject->globalData()->timeoutChecker.start(); -
trunk/WebCore/bindings/js/JSCustomSQLStatementCallback.cpp
r43283 r46370 55 55 return; 56 56 57 // FIXME: This is likely the wrong globalObject (for prototype chains at least) 57 58 JSGlobalObject* globalObject = m_frame->script()->globalObject(); 58 59 ExecState* exec = globalObject->globalExec(); … … 75 76 76 77 MarkedArgumentBuffer args; 77 args.append(toJS(exec, transaction));78 args.append(toJS(exec, resultSet));78 args.append(toJS(exec, deprecatedGlobalObjectForPrototype(exec), transaction)); 79 args.append(toJS(exec, deprecatedGlobalObjectForPrototype(exec), resultSet)); 79 80 80 81 globalObject->globalData()->timeoutChecker.start(); -
trunk/WebCore/bindings/js/JSCustomSQLStatementErrorCallback.cpp
r43283 r46370 55 55 if (!m_frame->script()->isEnabled()) 56 56 return true; 57 57 58 // FIXME: This is likely the wrong globalObject (for prototype chains at least) 58 59 JSGlobalObject* globalObject = m_frame->script()->globalObject(); 59 60 ExecState* exec = globalObject->globalExec(); … … 78 79 79 80 MarkedArgumentBuffer args; 80 args.append(toJS(exec, transaction));81 args.append(toJS(exec, error));81 args.append(toJS(exec, deprecatedGlobalObjectForPrototype(exec), transaction)); 82 args.append(toJS(exec, deprecatedGlobalObjectForPrototype(exec), error)); 82 83 83 84 JSValue result; -
trunk/WebCore/bindings/js/JSCustomSQLTransactionCallback.cpp
r43283 r46370 95 95 if (!m_data->frame()->script()->isEnabled()) 96 96 return; 97 97 98 // FIXME: This is likely the wrong globalObject (for prototype chains at least) 98 99 JSGlobalObject* globalObject = m_data->frame()->script()->globalObject(); 99 100 ExecState* exec = globalObject->globalExec(); … … 118 119 119 120 MarkedArgumentBuffer args; 120 args.append(toJS(exec, transaction));121 args.append(toJS(exec, deprecatedGlobalObjectForPrototype(exec), transaction)); 121 122 122 123 globalObject->globalData()->timeoutChecker.start(); -
trunk/WebCore/bindings/js/JSCustomSQLTransactionErrorCallback.cpp
r44155 r46370 55 55 return; 56 56 57 // FIXME: This is likely the wrong globalObject (for prototype chains at least) 57 58 JSGlobalObject* globalObject = m_frame->script()->globalObject(); 58 59 ExecState* exec = globalObject->globalExec(); … … 75 76 76 77 MarkedArgumentBuffer args; 77 args.append(toJS(exec, error));78 args.append(toJS(exec, deprecatedGlobalObjectForPrototype(exec), error)); 78 79 79 80 globalObject->globalData()->timeoutChecker.start(); -
trunk/WebCore/bindings/js/JSNodeFilterCondition.cpp
r43122 r46370 62 62 63 63 MarkedArgumentBuffer args; 64 args.append(toJS(exec, filterNode)); 64 // FIXME: The node should have the prototype chain that came from its document, not 65 // whatever prototype chain might be on the window this filter came from. Bug 27662 66 args.append(toJS(exec, deprecatedGlobalObjectForPrototype(exec), filterNode)); 65 67 if (exec->hadException()) 66 68 return NodeFilter::FILTER_REJECT; -
trunk/WebCore/bindings/js/JSWorkerConstructor.cpp
r46368 r46370 60 60 return 0; 61 61 62 // FIXME: Why do we use the lexical global object here?62 // See section 4.8.2 step 14 of WebWorkers for why this is the lexicalGlobalObject. 63 63 DOMWindow* window = asJSDOMWindow(exec->lexicalGlobalObject())->impl(); 64 64
Note: See TracChangeset
for help on using the changeset viewer.