Changeset 46421 in webkit


Ignore:
Timestamp:
Jul 27, 2009 11:17:27 AM (15 years ago)
Author:
Nate Chapin
Message:

2009-07-27 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Fix a regression introduced in r42671, which caused the js event
object to be hidden (some websites depend on being able to access it).

https://bugs.webkit.org/show_bug.cgi?id=27719

Location:
trunk/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r46420 r46421  
     12009-07-27  Nate Chapin  <japhet@chromium.org>
     2
     3        Reviewed by Dimitri Glazkov.
     4
     5        Fix a regression introduced in r42671, which caused the js event
     6        object to be hidden (some websites depend on being able to access it).
     7
     8        https://bugs.webkit.org/show_bug.cgi?id=27719
     9
     10        * bindings/v8/V8AbstractEventListener.cpp:
     11        (WebCore::V8AbstractEventListener::invokeEventHandler): Make the event object visible to javascript, instead of hidden.
     12
    1132009-07-27  Dumitru Daniliuc  <dumi@chromium.org>
    214
  • trunk/WebCore/bindings/v8/V8AbstractEventListener.cpp

    r45659 r46421  
    6868
    6969        // Save the old 'event' property so we can restore it later.
    70         v8::Local<v8::Value> savedEvent = v8Context->Global()->GetHiddenValue(eventSymbol);
     70        v8::Local<v8::Value> savedEvent = v8Context->Global()->Get(eventSymbol);
    7171        tryCatch.Reset();
    7272
    7373        // Make the event available in the global object, so DOMWindow can expose it.
    74         v8Context->Global()->SetHiddenValue(eventSymbol, jsEvent);
     74        v8Context->Global()->Set(eventSymbol, jsEvent);
    7575        tryCatch.Reset();
    7676
     
    8181        // Restore the old event. This must be done for all exit paths through this method.
    8282        if (savedEvent.IsEmpty())
    83             v8Context->Global()->SetHiddenValue(eventSymbol, v8::Undefined());
     83            v8Context->Global()->Set(eventSymbol, v8::Undefined());
    8484        else
    85             v8Context->Global()->SetHiddenValue(eventSymbol, savedEvent);
     85            v8Context->Global()->Set(eventSymbol, savedEvent);
    8686        tryCatch.Reset();
    8787    }
Note: See TracChangeset for help on using the changeset viewer.