Changeset 46466 in webkit

Timestamp:

Jul 28, 2009 3:52:59 AM (15 years ago)

Author:

xan@webkit.org

Message:

2009-07-28 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Do not cache the pango layout in the object, since the layout of
the page can change between calls.

• accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• accessibility/gtk/AccessibilityObjectWrapperAtk.cpp (modified) (3 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-07-28  Xan Lopez  <xlopez@igalia.com>
+
+        Reviewed by Gustavo Noronha.
+
+        https://bugs.webkit.org/show_bug.cgi?id=25415
+        [GTK][ATK] Please implement support for get_text_at_offset
+
+        Do not cache the pango layout in the object, since the layout of
+        the page can change between calls.
+
+        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
+
 2009-07-23  Anton Muhin  <antonm@chromium.org>
 

trunk/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp

@@ -507 +507 @@
 }
 
-// We can use the same callback for both 'style-set' and
-// 'direction-changed', since we don't care about neither of their
-// second parameters.
-static void updateLayout(GtkWidget* widget, gpointer dummy, gpointer userData)
-{
-   gpointer data = g_object_get_data(G_OBJECT(userData), "webkit-accessible-pango-layout");
-   if (!data)
-       return;
-
-   pango_layout_context_changed(static_cast<PangoLayout*>(data));
-}
-
 static gchar* utf8Substr(const gchar* string, gint start, gint end)
 {
@@ -563 +551 @@
 static PangoLayout* getPangoLayoutForAtk(AtkText* textObject)
 {
-    gpointer data = g_object_get_data(G_OBJECT(textObject), "webkit-accessible-pango-layout");
-    if (data)
-        return static_cast<PangoLayout*>(data);
-
     AccessibilityObject* coreObject = core(textObject);
 
@@ -575 +559 @@
     if (!webView)
         return 0;
-
-    g_signal_connect(webView, "style-set", G_CALLBACK(updateLayout), textObject);
-    g_signal_connect(webView, "direction-changed", G_CALLBACK(updateLayout), textObject);
 
     GString* str = g_string_new(NULL);