Changeset 46574 in webkit

Timestamp:

Jul 30, 2009 12:52:23 AM (15 years ago)

Author:

xan@webkit.org

Message:

2009-07-30 Xan Lopez <​xlopez@igalia.com>

Reviewed by Maciej Stachowiak.

​https://bugs.webkit.org/show_bug.cgi?id=25535
[GTK] object:state-changed:checked events missing for radio buttons and checkboxes

Implement state-changed:checked for radio buttons and checkboxes.

• accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::AXObjectCache::postPlatformNotification):
• html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setChecked):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• accessibility/gtk/AXObjectCacheAtk.cpp (modified) (1 diff)
• html/HTMLInputElement.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-07-30  Xan Lopez  <xlopez@igalia.com>
+
+        Reviewed by Maciej Stachowiak.
+
+        https://bugs.webkit.org/show_bug.cgi?id=25535
+        [GTK] object:state-changed:checked events missing for radio buttons and checkboxes
+
+        Implement state-changed:checked for radio buttons and checkboxes.
+
+        * accessibility/gtk/AXObjectCacheAtk.cpp:
+        (WebCore::AXObjectCache::postPlatformNotification):
+        * html/HTMLInputElement.cpp:
+        (WebCore::HTMLInputElement::setChecked):
+
 2009-07-30  Xan Lopez  <xlopez@igalia.com>
 

trunk/WebCore/accessibility/gtk/AXObjectCacheAtk.cpp

@@ -38 +38 @@
 }
 
-void AXObjectCache::postPlatformNotification(AccessibilityObject*, const String&)
+void AXObjectCache::postPlatformNotification(AccessibilityObject* coreObject, const String& message)
 {
+    if (message == "AXCheckedStateChanged") {
+        if (!coreObject->isCheckboxOrRadio())
+            return;
+        g_signal_emit_by_name(coreObject->wrapper(), "state-change", "checked", coreObject->isChecked());
+    }
 }
     

trunk/WebCore/html/HTMLInputElement.cpp

@@ -27 +27 @@
 #include "HTMLInputElement.h"
 
+#include "AXObjectCache.h"
 #include "CSSPropertyNames.h"
 #include "ChromeClient.h"
@@ -973 +974 @@
         renderer()->theme()->stateChanged(renderer(), CheckedState);
 
+    // Ideally we'd do this from the render tree (matching
+    // RenderTextView), but it's not possible to do it at the moment
+    // because of the way the code is structured.
+    if (renderer() && AXObjectCache::accessibilityEnabled())
+        renderer()->document()->axObjectCache()->postNotification(renderer(), "AXCheckedStateChanged", true);
+
     // Only send a change event for items in the document (avoid firing during
     // parsing) and don't send a change event for a radio button that's getting