Changeset 46769 in webkit

Timestamp:

Aug 4, 2009 10:28:16 AM (15 years ago)

Author:

Nate Chapin

Message:

2009-08-04 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Missed a place that expects window.event to be hidden when it shouldn't be.

​https://bugs.webkit.org/show_bug.cgi?id=27719

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/v8/custom/V8DOMWindowCustom.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-08-04  Nate Chapin  <japhet@chromium.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        Missed a place that expects window.event to be hidden when it shouldn't be.
+
+        https://bugs.webkit.org/show_bug.cgi?id=27719
+
+        * bindings/v8/custom/V8DOMWindowCustom.cpp:
+        (WebCore::ACCESSOR_GETTER): window.event is no longer hidden.
+
 2009-08-03  Chris Fleizach  <cfleizach@apple.com>
 

trunk/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp

@@ -148 +148 @@
     v8::Local<v8::String> eventSymbol = v8::String::NewSymbol("event");
     v8::Local<v8::Context> context = v8::Context::GetCurrent();
-    v8::Handle<v8::Value> jsEvent = context->Global()->GetHiddenValue(eventSymbol);
+    v8::Handle<v8::Value> jsEvent = context->Global()->Get(eventSymbol);
     if (jsEvent.IsEmpty())
         return v8::Undefined();