Changeset 46784 in webkit

Timestamp:

Aug 4, 2009 4:20:18 PM (15 years ago)

Author:

Nate Chapin

Message:

2009-08-04 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Revert r46421 and r46769, which appear to have totally hosed the v8 bindings.

​https://bugs.webkit.org/show_bug.cgi?id=27719

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/v8/V8AbstractEventListener.cpp (modified) (2 diffs)
• bindings/v8/custom/V8DOMWindowCustom.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-08-04  Nate Chapin  <japhet@chromium.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        Revert r46421 and r46769, which appear to have totally hosed the v8 bindings.
+
+        https://bugs.webkit.org/show_bug.cgi?id=27719
+
+        * bindings/v8/V8AbstractEventListener.cpp: Revert r46421.
+        (WebCore::V8AbstractEventListener::invokeEventHandler):
+        * bindings/v8/custom/V8DOMWindowCustom.cpp: Revert r46769.
+        (WebCore::ACCESSOR_GETTER):
+
 2009-08-04  Chris Fleizach  <cfleizach@apple.com>
 

trunk/WebCore/bindings/v8/V8AbstractEventListener.cpp

@@ -74 +74 @@
 
         // Save the old 'event' property so we can restore it later.
-        v8::Local<v8::Value> savedEvent = v8Context->Global()->Get(eventSymbol);
+        v8::Local<v8::Value> savedEvent = v8Context->Global()->GetHiddenValue(eventSymbol);
         tryCatch.Reset();
 
         // Make the event available in the global object, so DOMWindow can expose it.
-        v8Context->Global()->Set(eventSymbol, jsEvent);
+        v8Context->Global()->SetHiddenValue(eventSymbol, jsEvent);
         tryCatch.Reset();
 
@@ -87 +87 @@
         // Restore the old event. This must be done for all exit paths through this method.
         if (savedEvent.IsEmpty())
-            v8Context->Global()->Set(eventSymbol, v8::Undefined());
+            v8Context->Global()->SetHiddenValue(eventSymbol, v8::Undefined());
         else
-            v8Context->Global()->Set(eventSymbol, savedEvent);
+            v8Context->Global()->SetHiddenValue(eventSymbol, savedEvent);
         tryCatch.Reset();
     }

trunk/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp

@@ -148 +148 @@
     v8::Local<v8::String> eventSymbol = v8::String::NewSymbol("event");
     v8::Local<v8::Context> context = v8::Context::GetCurrent();
-    v8::Handle<v8::Value> jsEvent = context->Global()->Get(eventSymbol);
+    v8::Handle<v8::Value> jsEvent = context->Global()->GetHiddenValue(eventSymbol);
     if (jsEvent.IsEmpty())
         return v8::Undefined();