Changeset 46869 in webkit
- Timestamp:
- Aug 6, 2009 4:45:37 PM (15 years ago)
- Location:
- trunk
- Files:
-
- 8 added
- 12 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r46861 r46869 1 2009-08-06 Michelangelo De Simone <micdesim@gmail.com> 2 3 Reviewed by Darin Adler. 4 5 https://bugs.webkit.org/show_bug.cgi?id=27455 6 Test suite for form controls' custom validation message. 7 8 * fast/dom/domListEnumeration-expected.txt: Corrected 9 * fast/dom/resources/domListEnumeration.js: Corrected 10 * fast/forms/ValidityState-customError-001-expected.txt: Added. 11 * fast/forms/ValidityState-customError-001.html: Added. 12 * fast/forms/ValidityState-customError-002-expected.txt: Added. 13 * fast/forms/ValidityState-customError-002.html: Added. 14 * fast/forms/ValidityState-customError-003-expected.txt: Added. 15 * fast/forms/ValidityState-customError-003.html: Added. 16 * fast/forms/ValidityState-customError-004-expected.txt: Added. 17 * fast/forms/ValidityState-customError-004.html: Added. 18 1 19 2009-08-06 Ryosuke Niwa <rniwa@webkit.org> 2 20 -
trunk/LayoutTests/fast/dom/domListEnumeration-expected.txt
r45888 r46869 42 42 43 43 [object HTMLSelectElement] 44 PASS resultArray.length is 13 744 PASS resultArray.length is 138 45 45 PASS resultArray[0].i is '0' 46 46 PASS resultArray[0].item is document.getElementsByTagName('option')[0] -
trunk/LayoutTests/fast/dom/resources/domListEnumeration.js
r45888 r46869 142 142 var htmlSelectElement = document.getElementsByTagName('select')[0]; 143 143 resultArray = iterateList(htmlSelectElement); 144 shouldBe("resultArray.length", "13 7");144 shouldBe("resultArray.length", "138"); 145 145 shouldBe("resultArray[0].i", "'0'"); 146 146 shouldBe("resultArray[0].item", "document.getElementsByTagName('option')[0]"); -
trunk/WebCore/ChangeLog
r46868 r46869 1 2009-08-06 Michelangelo De Simone <micdesim@gmail.com> 2 3 Reviewed by Darin Adler. 4 5 https://bugs.webkit.org/show_bug.cgi?id=27455 6 Support for a custom validation message in ValidityState and related 7 form controls. 8 http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#dom-cva-setcustomvalidity 9 10 Tests: fast/forms/ValidityState-customError-001.html 11 fast/forms/ValidityState-customError-002.html 12 fast/forms/ValidityState-customError-003.html 13 fast/forms/ValidityState-customError-004.html 14 15 * html/HTMLButtonElement.idl: setCustomValidity DOM method 16 * html/HTMLFieldSetElement.idl: ditto 17 * html/HTMLFormControlElement.cpp: 18 (WebCore::HTMLFormControlElement::setCustomValidity): ditto 19 * html/HTMLFormControlElement.h: 20 (WebCore::HTMLFormControlElement::valueMissing): moved down 21 * html/HTMLInputElement.idl: ditto 22 * html/HTMLSelectElement.idl: ditto 23 * html/HTMLTextAreaElement.idl: 24 * html/ValidityState.h: 25 (WebCore::ValidityState::setCustomErrorMessage): method to set custom 26 validation message 27 (WebCore::ValidityState::customError): validation flag 28 1 29 2009-08-06 Mark Rowe <mrowe@apple.com> 2 30 -
trunk/WebCore/html/HTMLButtonElement.idl
r45888 r46869 37 37 attribute [ConvertNullToNullString] DOMString value; 38 38 readonly attribute boolean willValidate; 39 void setCustomValidity(in [ConvertUndefinedOrNullToNullString] DOMString error); 39 40 void click(); 40 41 }; -
trunk/WebCore/html/HTMLFieldSetElement.idl
r45888 r46869 30 30 #endif 31 31 readonly attribute boolean willValidate; 32 void setCustomValidity(in [ConvertUndefinedOrNullToNullString] DOMString error); 32 33 }; 33 34 -
trunk/WebCore/html/HTMLFormControlElement.cpp
r46062 r46869 263 263 return form() && name().length() && !disabled() && !isReadOnlyFormControl(); 264 264 } 265 266 void HTMLFormControlElement::setCustomValidity(const String& error) 267 { 268 validity()->setCustomErrorMessage(error); 269 } 265 270 266 271 void HTMLFormControlElement::dispatchFocusEvent() -
trunk/WebCore/html/HTMLFormControlElement.h
r46423 r46869 78 78 void setRequired(bool); 79 79 80 virtual bool valueMissing() const { return false; }81 82 80 virtual void recalcStyle(StyleChange); 83 81 … … 105 103 106 104 virtual bool willValidate() const; 105 void setCustomValidity(const String&); 107 106 107 virtual bool valueMissing() const { return false; } 108 108 virtual bool patternMismatch() const { return false; } 109 109 -
trunk/WebCore/html/HTMLInputElement.idl
r46423 r46869 57 57 attribute [ConvertNullToNullString] DOMString value; 58 58 readonly attribute boolean willValidate; 59 void setCustomValidity(in [ConvertUndefinedOrNullToNullString] DOMString error); 59 60 void select(); 60 61 void click(); -
trunk/WebCore/html/HTMLSelectElement.idl
r45888 r46869 46 46 #endif 47 47 readonly attribute boolean willValidate; 48 void setCustomValidity(in [ConvertUndefinedOrNullToNullString] DOMString error); 48 49 49 50 // Modified in DOM Level 2: -
trunk/WebCore/html/HTMLTextAreaElement.idl
r46062 r46869 45 45 46 46 readonly attribute boolean willValidate; 47 void setCustomValidity(in [ConvertUndefinedOrNullToNullString] DOMString error); 47 48 48 49 // WinIE & FireFox extension: -
trunk/WebCore/html/ValidityState.h
r46423 r46869 39 39 HTMLFormControlElement* control() const { return m_control; } 40 40 41 void setCustomErrorMessage(const String& message) { m_customErrorMessage = message; } 42 41 43 bool valueMissing() { return control()->valueMissing(); } 42 44 bool typeMismatch() { return false; } … … 46 48 bool rangeOverflow() { return false; } 47 49 bool stepMismatch() { return false; } 48 bool customError() { return false; }50 bool customError() { return !m_customErrorMessage.isEmpty(); } 49 51 bool valid(); 50 52 … … 52 54 ValidityState(HTMLFormControlElement*); 53 55 HTMLFormControlElement* m_control; 56 String m_customErrorMessage; 54 57 }; 55 58
Note: See TracChangeset
for help on using the changeset viewer.