Changeset 46886 in webkit

Timestamp:

Aug 6, 2009 10:51:45 PM (15 years ago)

Author:

abarth@webkit.org

Message:

2009-08-06 Joseph Pecoraro <​joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

Inspector: NodeLists Don't Display Well in the Console
​https://bugs.webkit.org/show_bug.cgi?id=28061

• inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._format): Specific check if the object is a NodeList, display as an "array"

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/ConsoleView.js (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-08-06  Joseph Pecoraro  <joepeck02@gmail.com>
+
+        Reviewed by Timothy Hatcher.
+
+        Inspector: NodeLists Don't Display Well in the Console
+        https://bugs.webkit.org/show_bug.cgi?id=28061
+
+        * inspector/front-end/ConsoleView.js:
+        (WebInspector.ConsoleView.prototype._format): Specific check if the object is a NodeList, display as an "array"
+
 2009-08-06  Yusuke Sato  <yusukes@chromium.org>
 

trunk/WebCore/inspector/front-end/ConsoleView.js

@@ -437 +437 @@
     _format: function(output, forceObjectFormat)
     {
-        var type = (forceObjectFormat ? "object" : Object.type(output, InspectorController.inspectedWindow()));
+        var inspectedWindow = InspectorController.inspectedWindow();
+        if (forceObjectFormat)
+            var type = "object";
+        else if (output instanceof inspectedWindow.NodeList)
+            var type = "array";
+        else
+            var type = Object.type(output, inspectedWindow);
 
         // We don't perform any special formatting on these types, so we just