Changeset 46888 in webkit


Ignore:
Timestamp:
Aug 6, 2009 11:53:08 PM (15 years ago)
Author:
abarth@webkit.org
Message:

2009-08-06 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Adam Barth.

box-shadow's spread is ignored with <table>
https://bugs.webkit.org/show_bug.cgi?id=28017

Use RenderStyle::getBoxShadowExtent just like RenderBlock.

  • fast/box-shadow/box-shadow-overflow-scroll-expected.txt: Added.
  • fast/box-shadow/box-shadow-overflow-scroll.html: Added.
  • fast/box-shadow/resources/box-shadow-overflow-scroll.js: Added.

2009-08-06 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Adam Barth.

box-shadow's spread is ignored with <table>
https://bugs.webkit.org/show_bug.cgi?id=28017

Use RenderStyle::getBoxShadowExtent just like RenderBlock.

Test: fast/box-shadow/box-shadow-overflow-scroll.html

  • rendering/RenderTable.cpp: (WebCore::RenderTable::layout):

2009-08-06 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Adam Barth.

box-shadow's spread is ignored with <table>
https://bugs.webkit.org/show_bug.cgi?id=28017

Use RenderStyle::getBoxShadowExtent just like RenderBlock.

  • Scripts/make-js-test-wrappers: Added regexp to skip box-shadow-overflow-scroll.js
Location:
trunk
Files:
4 added
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r46887 r46888  
     12009-08-06  Shinichiro Hamaji  <hamaji@chromium.org>
     2
     3        Reviewed by Adam Barth.
     4
     5        box-shadow's spread is ignored with <table>
     6        https://bugs.webkit.org/show_bug.cgi?id=28017
     7
     8        Use RenderStyle::getBoxShadowExtent just like RenderBlock.
     9
     10        * fast/box-shadow/box-shadow-overflow-scroll-expected.txt: Added.
     11        * fast/box-shadow/box-shadow-overflow-scroll.html: Added.
     12        * fast/box-shadow/resources/box-shadow-overflow-scroll.js: Added.
     13
    1142009-08-06  Jan Michael Alonzo  <jmalonzo@webkit.org>
    215
  • trunk/WebCore/ChangeLog

    r46886 r46888  
     12009-08-06  Shinichiro Hamaji  <hamaji@chromium.org>
     2
     3        Reviewed by Adam Barth.
     4
     5        box-shadow's spread is ignored with <table>
     6        https://bugs.webkit.org/show_bug.cgi?id=28017
     7
     8        Use RenderStyle::getBoxShadowExtent just like RenderBlock.
     9
     10        Test: fast/box-shadow/box-shadow-overflow-scroll.html
     11
     12        * rendering/RenderTable.cpp:
     13        (WebCore::RenderTable::layout):
     14
    1152009-08-06  Joseph Pecoraro  <joepeck02@gmail.com>
    216
  • trunk/WebCore/rendering/RenderTable.cpp

    r46647 r46888  
    391391
    392392    if (!hasOverflowClip()) {
    393         for (ShadowData* boxShadow = style()->boxShadow(); boxShadow; boxShadow = boxShadow->next) {
    394             m_overflowLeft = min(m_overflowLeft, boxShadow->x - boxShadow->blur);
    395             m_overflowWidth = max(m_overflowWidth, width() + boxShadow->x + boxShadow->blur);
    396             m_overflowTop = min(m_overflowTop, boxShadow->y - boxShadow->blur);
    397             m_overflowHeight = max(m_overflowHeight, height() + boxShadow->y + boxShadow->blur);
    398         }
    399        
     393        int shadowLeft;
     394        int shadowRight;
     395        int shadowTop;
     396        int shadowBottom;
     397        style()->getBoxShadowExtent(shadowTop, shadowRight, shadowBottom, shadowLeft);
     398
     399        m_overflowLeft = min(m_overflowLeft, shadowLeft);
     400        m_overflowWidth = max(m_overflowWidth, width() + shadowRight);
     401        m_overflowTop = min(m_overflowTop, shadowTop);
     402        m_overflowHeight = max(m_overflowHeight, height() + shadowBottom);
     403
    400404        if (hasReflection()) {
    401405            IntRect reflection(reflectionBox());
  • trunk/WebKitTools/ChangeLog

    r46856 r46888  
     12009-08-06  Shinichiro Hamaji  <hamaji@chromium.org>
     2
     3        Reviewed by Adam Barth.
     4
     5        box-shadow's spread is ignored with <table>
     6        https://bugs.webkit.org/show_bug.cgi?id=28017
     7
     8        Use RenderStyle::getBoxShadowExtent just like RenderBlock.
     9
     10        * Scripts/make-js-test-wrappers: Added regexp to skip box-shadow-overflow-scroll.js
     11
    1122009-08-06  Eric Seidel  <eric@webkit.org>
    213
  • trunk/WebKitTools/Scripts/make-js-test-wrappers

    r46855 r46888  
    9999        next if $file =~ m:resources/altGlyph-dom\.js$:;
    100100        next if $file =~ m:resources/attr-case-sensitivity\.js$:;
     101        next if $file =~ m:resources/box-shadow-overflow-scroll\.js$:;
    101102        next if $file =~ m:resources/codegen-temporaries-multiple-global-blocks-1\.js$:;
    102103        next if $file =~ m:resources/codegen-temporaries-multiple-global-blocks-2\.js$:;
Note: See TracChangeset for help on using the changeset viewer.