Changeset 46915 in webkit


Ignore:
Timestamp:
Aug 7, 2009 2:39:03 PM (15 years ago)
Author:
ajwong@chromium.org
Message:

WebCore: Right click on timeline of media controls panel cause seek
https://bugs.webkit.org/show_bug.cgi?id=27920

Patch by Alpha Lam <hclam@chromium.org> on 2009-08-07
Reviewed by Eric Seidel.

Add a test simulate the behavior of seeking by right clicking
on the time bar of media controls while playing.

  • media/controls-right-click-on-timebar-expected.txt: Added.
  • media/controls-right-click-on-timebar.html: Added.

LayoutTests: Right click on timeline of media controls panel cause seek
https://bugs.webkit.org/show_bug.cgi?id=27920

Patch by Alpha Lam <hclam@chromium.org> on 2009-08-07
Reviewed by Eric Seidel.

Add a test simulate the behavior of seeking by right clicking
on the time bar of media controls while playing.

  • media/controls-right-click-on-timebar-expected.txt: Added.
  • media/controls-right-click-on-timebar.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r46913 r46915  
     12009-08-07  Alpha Lam  <hclam@chromium.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        Right click on timeline of media controls panel cause seek
     6        https://bugs.webkit.org/show_bug.cgi?id=27920
     7
     8        Add a test simulate the behavior of seeking by right clicking
     9        on the time bar of media controls while playing.
     10
     11        * media/controls-right-click-on-timebar-expected.txt: Added.
     12        * media/controls-right-click-on-timebar.html: Added.
     13
    1142009-08-07  Darin Adler  <darin@apple.com>
    215
  • trunk/WebCore/ChangeLog

    r46914 r46915  
     12009-08-07  Alpha Lam  <hclam@chromium.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        Right click on timeline of media controls panel cause seek
     6        https://bugs.webkit.org/show_bug.cgi?id=27920
     7
     8        Add a test simulate the behavior of seeking by right clicking
     9        on the time bar of media controls while playing.
     10
     11        * media/controls-right-click-on-timebar-expected.txt: Added.
     12        * media/controls-right-click-on-timebar.html: Added.
     13
    1142009-08-07  Ryosuke Niwa  <rniwa@webkit.org>
    215
  • trunk/WebCore/rendering/MediaControlElements.cpp

    r46815 r46915  
    483483void MediaControlTimelineElement::defaultEventHandler(Event* event)
    484484{
     485    // Left button is 0. Accepts only if mouse event is from left button.
     486    if (!event->isMouseEvent() || static_cast<MouseEvent*>(event)->button())
     487        return;
     488
    485489    if (event->type() == eventNames().mousedownEvent)
    486490        m_mediaElement->beginScrubbing();
Note: See TracChangeset for help on using the changeset viewer.