Changeset 46919 in webkit

Timestamp:

Aug 7, 2009 3:36:47 PM (15 years ago)

Author:

abarth@webkit.org

Message:

2009-08-07 Jian Li <​jianli@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Do not register V8 error message listener in WorkerContextExecutionProxy.
​https://bugs.webkit.org/show_bug.cgi?id=28082

• bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::initV8IfNeeded):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/v8/WorkerContextExecutionProxy.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-08-07  Jian Li  <jianli@chromium.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        [V8] Do not register V8 error message listener in WorkerContextExecutionProxy.
+        https://bugs.webkit.org/show_bug.cgi?id=28082
+
+        * bindings/v8/WorkerContextExecutionProxy.cpp:
+        (WebCore::WorkerContextExecutionProxy::initV8IfNeeded):
+
 2009-08-07  Kwang Yul Seo  <skyul@company100.net>
 

trunk/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp

@@ -64 +64 @@
 }
 
-static void handleConsoleMessage(v8::Handle<v8::Message> message, v8::Handle<v8::Value> data)
-{
-    WorkerContextExecutionProxy* proxy = WorkerContextExecutionProxy::retrieve();
-    if (!proxy)
-        return;
-
-    WorkerContext* workerContext = proxy->workerContext();
-    if (!workerContext)
-        return;
-
-    v8::Handle<v8::String> errorMessageString = message->Get();
-    ASSERT(!errorMessageString.IsEmpty());
-    String errorMessage = toWebCoreString(errorMessageString);
-
-    v8::Handle<v8::Value> resourceName = message->GetScriptResourceName();
-    bool useURL = (resourceName.IsEmpty() || !resourceName->IsString());
-    String resourceNameString = useURL ? workerContext->url() : toWebCoreString(resourceName);
-
-    workerContext->addMessage(ConsoleDestination, JSMessageSource, LogMessageType, ErrorMessageLevel, errorMessage, message->GetLineNumber(), resourceNameString);
-}
-
 WorkerContextExecutionProxy::WorkerContextExecutionProxy(WorkerContext* workerContext)
     : m_workerContext(workerContext)
@@ -148 +127 @@
     v8::V8::SetFatalErrorHandler(reportFatalErrorInV8);
 
-    // Set up the handler for V8 error message.
-    v8::V8::AddMessageListener(handleConsoleMessage);
-
     v8Initialized = true;
 }