Changeset 46939 in webkit

Timestamp:

Aug 7, 2009 6:25:07 PM (15 years ago)

Author:

abarth@webkit.org

Message:

2009-08-07 Yong Li <​yong.li@torchmobile.com>

WINCE PORT: store only width for GlyphBufferAdvance, to save space on low-memory devices
​https://bugs.webkit.org/show_bug.cgi?id=27734

• platform/graphics/GlyphBuffer.h: (WebCore::GlyphBuffer::advanceAt): (WebCore::GlyphBuffer::advanceData): (WebCore::GlyphBuffer::add):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/GlyphBuffer.h (modified) (7 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-08-07  Yong Li  <yong.li@torchmobile.com>
+
+        WINCE PORT: store only width for GlyphBufferAdvance, to save space on low-memory devices
+        https://bugs.webkit.org/show_bug.cgi?id=27734
+
+        * platform/graphics/GlyphBuffer.h:
+        (WebCore::GlyphBuffer::advanceAt):
+        (WebCore::GlyphBuffer::advanceData):
+        (WebCore::GlyphBuffer::add):
+
 2009-08-07  Yong Li  <yong.li@torchmobile.com>
 

trunk/WebCore/platform/graphics/GlyphBuffer.h

@@ -1 +1 @@
 /*
  * Copyright (C) 2006, 2009 Apple Inc. All rights reserved.
+ * Copyright (C) 2007-2008 Torch Mobile Inc.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -50 +51 @@
 // FIXME: Why does Cairo use such a huge struct instead of just an offset into an array?
 typedef cairo_glyph_t GlyphBufferGlyph;
+#elif PLATFORM(WINCE)
+typedef wchar_t GlyphBufferGlyph;
 #else
 typedef Glyph GlyphBufferGlyph;
@@ -58 +61 @@
 #if PLATFORM(CG)
 typedef CGSize GlyphBufferAdvance;
+#elif PLATFORM(WINCE)
+// There is no cross-platform code that uses the height of GlyphBufferAdvance,
+// so we can save memory space on embedded devices by storing only the width
+typedef float GlyphBufferAdvance;
 #else
 typedef FloatSize GlyphBufferAdvance;
@@ -118 +125 @@
 #if PLATFORM(CG)
         return m_advances[index].width;
+#elif PLATFORM(WINCE)
+        return m_advances[index];
 #else
         return m_advances[index].width();
 #endif
     }
+
+#if PLATFORM(WINCE)
+    const GlyphBufferAdvance* advanceData() const
+    {
+        return m_advances.data();
+    }
+#endif
 
     FloatSize offsetAt(int index) const
@@ -148 +164 @@
         CGSize advance = { width, 0 };
         m_advances.append(advance);
+#elif PLATFORM(WINCE)
+        m_advances.append(width);
 #else
         m_advances.append(FloatSize(width, 0));
@@ -162 +180 @@
     }
     
+#if !PLATFORM(WINCE)
     void add(Glyph glyph, const SimpleFontData* font, GlyphBufferAdvance advance)
     {
@@ -175 +194 @@
         m_advances.append(advance);
     }
+#endif
     
 private: