Changeset 47121 in webkit

Timestamp:

Aug 12, 2009 10:18:44 AM (15 years ago)

Author:

Adam Roben

Message:

Don't try to seek to the end of stdin on Cygwin

Doing so seems to always cause an exception (for unknown reasons).

Fixes <​http://webkit.org/b/28159> create-bug throws an exception in
Cygwin

Reviewed by Dave Kilzer.

• Scripts/bugzilla-tool:

(CreateBug.prompt_for_bug_title_and_comments): Ignore IOErrors
generated by calling sys.stdin.seek, since these seem to be generated
for no good reason on Cygwin.

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/bugzilla-tool (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2009-08-12  Adam Roben  <aroben@apple.com>
+
+        Don't try to seek to the end of stdin on Cygwin
+
+        Doing so seems to always cause an exception (for unknown reasons).
+
+        Fixes <http://webkit.org/b/28159> create-bug throws an exception in
+        Cygwin
+
+        Reviewed by Dave Kilzer.
+
+        * Scripts/bugzilla-tool:
+        (CreateBug.prompt_for_bug_title_and_comments): Ignore IOErrors
+        generated by calling sys.stdin.seek, since these seem to be generated
+        for no good reason on Cygwin.
+
 2009-08-12  Adam Roben  <aroben@apple.com>
 

trunk/WebKitTools/Scripts/bugzilla-tool

@@ -555 +555 @@
         print "Bug comment (hit ^D on blank line to end):"
         lines = sys.stdin.readlines()
-        sys.stdin.seek(0, os.SEEK_END)
+        try:
+            sys.stdin.seek(0, os.SEEK_END)
+        except IOError:
+            # Cygwin raises an Illegal Seek (errno 29) exception when the above
+            # seek() call is made. Ignoring it seems to cause no harm.
+            # FIXME: Figure out a way to get avoid the exception in the first
+            # place.
+            pass
+        else:
+            raise
         comment_text = ''.join(lines)
         return (bug_title, comment_text)