Changeset 47489 in webkit


Ignore:
Timestamp:
Aug 18, 2009 10:09:35 PM (15 years ago)
Author:
mjs@apple.com
Message:

2009-08-13 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Sam Weinig.

<nav> should behave essentially the same as <div> for parsing
etc. This is implemented by the changes below.


Tests: fast/html/nav-element.html

  • css/html.css:
  • editing/htmlediting.cpp: (WebCore::validBlockTag):
  • html/HTMLElement.cpp: (WebCore::HTMLElement::tagPriority): (WebCore::blockTagList):
  • html/HTMLParser.cpp: (WebCore::HTMLParser::getNode):
  • html/HTMLTagNames.in:

2009-08-13 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Sam Weinig.

Test aspects of <nav>, including residual style, <p> closing, and FormatBlock.


  • fast/html/nav-element-expected.txt: Added.
  • fast/html/nav-element.html: Added.
Location:
trunk
Files:
2 added
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r47472 r47489  
     12009-08-13  Maciej Stachowiak  <mjs@apple.com>
     2
     3        Reviewed by Sam Weinig.
     4
     5        - Tests for: Implement HTML5 nav element
     6        https://bugs.webkit.org/show_bug.cgi?id=27937
     7
     8        Test aspects of <nav>, including residual style, <p> closing, and FormatBlock.
     9       
     10        * fast/html/nav-element-expected.txt: Added.
     11        * fast/html/nav-element.html: Added.
     12
    1132009-08-18  Oliver Hunt  <oliver@apple.com>
    214

  • trunk/WebCore/ChangeLog

    r47482 r47489  
     12009-08-13  Maciej Stachowiak  <mjs@apple.com>
     2
     3        Reviewed by Sam Weinig.
     4
     5        - Implement HTML5 nav element
     6        https://bugs.webkit.org/show_bug.cgi?id=27937
     7
     8        <nav> should behave essentially the same as <div> for parsing
     9        etc. This is implemented by the changes below.
     10       
     11        Tests: fast/html/nav-element.html
     12
     13        * css/html.css:
     14        * editing/htmlediting.cpp:
     15        (WebCore::validBlockTag):
     16        * html/HTMLElement.cpp:
     17        (WebCore::HTMLElement::tagPriority):
     18        (WebCore::blockTagList):
     19        * html/HTMLParser.cpp:
     20        (WebCore::HTMLParser::getNode):
     21        * html/HTMLTagNames.in:
     22
    1232009-08-18  Anders Carlsson  <andersca@apple.com>
    224

  • trunk/WebCore/css/html.css

    r47420 r47489  
    7373}
    7474
     75nav {
     76    display: block
     77}
     78
    7579marquee {
    7680    display: inline-block;

  • trunk/WebCore/editing/htmlediting.cpp

    r46681 r47489  
    462462bool validBlockTag(const String& blockTag)
    463463{
     464    // FIXME: convert this to a HashSet
    464465    if (blockTag == "address" ||
    465466        blockTag == "blockquote" ||
    … …  
    474475        blockTag == "h5" ||
    475476        blockTag == "h6" ||
     477        blockTag == "nav" ||
    476478        blockTag == "p" ||
    477479        blockTag == "pre")

  • trunk/WebCore/html/HTMLElement.cpp

    r47420 r47489  
    9393    if (hasLocalName(addressTag) || hasLocalName(ddTag) || hasLocalName(dtTag) || hasLocalName(noscriptTag) || hasLocalName(rpTag) || hasLocalName(rtTag))
    9494        return 3;
    95     if (hasLocalName(centerTag) || hasLocalName(nobrTag) || hasLocalName(rubyTag))
     95    if (hasLocalName(centerTag) || hasLocalName(nobrTag) || hasLocalName(rubyTag) || hasLocalName(navTag))
    9696        return 5;
    9797    if (hasLocalName(noembedTag) || hasLocalName(noframesTag))
    … …  
    883883        tagList.add(marqueeTag.localName().impl());
    884884        tagList.add(menuTag.localName().impl());
     885        tagList.add(navTag.localName().impl());
    885886        tagList.add(noembedTag.localName().impl());
    886887        tagList.add(noframesTag.localName().impl());

  • trunk/WebCore/html/HTMLParser.cpp

    r47420 r47489  
    922922        gFunctionMap.set(mapTag.localName().impl(), &HTMLParser::mapCreateErrorCheck);
    923923        gFunctionMap.set(menuTag.localName().impl(), &HTMLParser::pCloserCreateErrorCheck);
     924        gFunctionMap.set(navTag.localName().impl(), &HTMLParser::pCloserCreateErrorCheck);
    924925        gFunctionMap.set(nobrTag.localName().impl(), &HTMLParser::nestedCreateErrorCheck);
    925926        gFunctionMap.set(noembedTag.localName().impl(), &HTMLParser::noembedCreateErrorCheck);

  • trunk/WebCore/html/HTMLTagNames.in

    r47469 r47489  
    7373menu createWithNew
    7474meta createWithNew
     75nav interfaceName=HTMLElement, createWithNew
    7576nobr interfaceName=HTMLElement, createWithNew
    7677noembed interfaceName=HTMLElement, createWithNew
Note: See TracChangeset for help on using the changeset viewer.