Changeset 48401 in webkit

Timestamp:

Sep 15, 2009 2:26:26 PM (15 years ago)

Author:

Simon Fraser

Message:

2009-09-15 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Fixed position elements flash when CSS transforms are applied on page > 2048px tall
​https://bugs.webkit.org/show_bug.cgi?id=27272

Update the previous workaround for misplaced compositing layers, which used a 4096px
threshold, to 2048px since that's the GPU max texture size on some older hardware.

• WebView/WebHTMLView.mm: (-[WebHTMLView _updateLayerHostingViewPosition]):

Location:

trunk/WebKit/mac

Files:

• ChangeLog (modified) (1 diff)
• WebView/WebHTMLView.mm (modified) (2 diffs)

trunk/WebKit/mac/ChangeLog

@@ +1 @@
+2009-09-15  Simon Fraser  <simon.fraser@apple.com>
+
+        Reviewed by Dan Bernstein.
+
+        Fixed position elements flash when CSS transforms are applied on page > 2048px tall
+        https://bugs.webkit.org/show_bug.cgi?id=27272
+        
+        Update the previous workaround for misplaced compositing layers, which used a 4096px
+        threshold, to 2048px since that's the GPU max texture size on some older hardware.
+
+        * WebView/WebHTMLView.mm:
+        (-[WebHTMLView _updateLayerHostingViewPosition]):
+
 2009-09-15  Alex Milowski  <alex@milowski.com>
 

trunk/WebKit/mac/WebView/WebHTMLView.mm

@@ -5463 +5463 @@
         return;
     
-    const CGFloat maxHeight = 4096;
+    const CGFloat maxHeight = 2048;
     NSRect layerViewFrame = [self bounds];
 
@@ -5469 +5469 @@
         CGFloat documentHeight = layerViewFrame.size.height;
             
-        // Clamp the size of the view to <= 4096px to avoid the bug.
+        // Clamp the size of the view to <= maxHeight to avoid the bug.
         layerViewFrame.size.height = maxHeight;
         NSRect visibleRect = [[self enclosingScrollView] documentVisibleRect];