Changeset 48486 in webkit

Timestamp:

Sep 17, 2009 12:59:50 PM (15 years ago)

Author:

eric@webkit.org

Message:

2009-09-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[V8] OwnHandle might get a weak callback after destruction
​https://bugs.webkit.org/show_bug.cgi?id=29172

Be sure to clear out weak reference so we don't get a weak callback
after we've destructed ourselves. Also, removed some tricky methods
that had no clients.

• bindings/v8/OwnHandle.h: (WebCore::OwnHandle::clear):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/v8/OwnHandle.h (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-09-17  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        [V8] OwnHandle might get a weak callback after destruction
+        https://bugs.webkit.org/show_bug.cgi?id=29172
+
+        Be sure to clear out weak reference so we don't get a weak callback
+        after we've destructed ourselves.  Also, removed some tricky methods
+        that had no clients.
+
+        * bindings/v8/OwnHandle.h:
+        (WebCore::OwnHandle::clear):
+
 2009-09-17  Dimitri Glazkov  <dglazkov@chromium.org>
 

trunk/WebCore/bindings/v8/OwnHandle.h

@@ -46 +46 @@
         void set(v8::Handle<T> handle) { clear(); m_handle = v8::Persistent<T>::New(handle); }
 
-        // FIXME: What if we release a weak handle?  Won't the callback do the wrong thing?
-        v8::Persistent<T> release() { v8::Persistent<T> result = m_handle; m_handle.Clear(); return result; }
-        void adopt(v8::Persistent<T> handle) { clear(); m_handle = handle; }
-
         // Note: This is clear in the OwnPtr sense, not the v8::Handle sense.
         void clear()
@@ -55 +51 @@
             if (m_handle.IsEmpty())
                 return;
+            if (m_handle.IsWeak())
+                m_handle.ClearWeak();
             m_handle.Dispose();
             m_handle.Clear();