Changeset 48541 in webkit

Timestamp:

Sep 18, 2009 3:25:23 PM (15 years ago)

Author:

beidson@apple.com

Message:

Speculative fix for:
​https://bugs.webkit.org/show_bug.cgi?id=29322
and
​https://bugs.webkit.org/show_bug.cgi?id=29505

Reviewed by Alexey Proskuryakov.

Adding a "Connection: close" header might make the tests work more reliably,
and doesn't seem to make anything worse: They all continue to pass on my machine!

• http/tests/loading/resources/basic-auth-testing.php:
• http/tests/loading/resources/othersubresources/protected-resource.php:
• http/tests/loading/resources/protected-resource.php:
• http/tests/loading/resources/subresources/protected-resource.php:
• http/tests/xmlhttprequest/resources/cross-origin-authorization.php:
• http/tests/xmlhttprequest/resources/cross-origin-check-cookies.php:
• http/tests/xmlhttprequest/resources/cross-origin-no-authorization.php:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• http/tests/loading/resources/basic-auth-testing.php (modified) (1 diff)
• http/tests/loading/resources/othersubresources/protected-resource.php (modified) (1 diff)
• http/tests/loading/resources/protected-resource.php (modified) (1 diff)
• http/tests/loading/resources/subresources/protected-resource.php (modified) (1 diff)
• http/tests/xmlhttprequest/resources/cross-origin-authorization.php (modified) (1 diff)
• http/tests/xmlhttprequest/resources/cross-origin-check-cookies.php (modified) (1 diff)
• http/tests/xmlhttprequest/resources/cross-origin-no-authorization.php (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2009-09-18  Brady Eidson  <beidson@apple.com>
+
+        Reviewed by Alexey Proskuryakov.
+
+        Speculative fix for:
+        https://bugs.webkit.org/show_bug.cgi?id=29322
+        and
+        https://bugs.webkit.org/show_bug.cgi?id=29505
+
+        Adding a "Connection: close" header might make the tests work more reliably, 
+        and doesn't seem to make anything worse: They all continue to pass on my machine!
+
+        * http/tests/loading/resources/basic-auth-testing.php:
+        * http/tests/loading/resources/othersubresources/protected-resource.php:
+        * http/tests/loading/resources/protected-resource.php:
+        * http/tests/loading/resources/subresources/protected-resource.php:
+        * http/tests/xmlhttprequest/resources/cross-origin-authorization.php:
+        * http/tests/xmlhttprequest/resources/cross-origin-check-cookies.php:
+        * http/tests/xmlhttprequest/resources/cross-origin-no-authorization.php:
+
 2009-09-18  Alpha Lam  <hclam@chromium.org>
 

trunk/LayoutTests/http/tests/loading/resources/basic-auth-testing.php

@@ -5 +5 @@
 
 header("Cache-Control: no-store");
+header("Connection: close");
 if (!isset($_SERVER['PHP_AUTH_USER']) || $_SERVER['PHP_AUTH_USER'] != $expectedUsername ||  
     !isset($_SERVER['PHP_AUTH_PW']) || $_SERVER['PHP_AUTH_PW'] != $expectedPassword) {

trunk/LayoutTests/http/tests/loading/resources/othersubresources/protected-resource.php

@@ -1 +1 @@
 <?php
 header("Cache-Control: no-store");
+header("Connection: close");
 if (!isset($_SERVER['PHP_AUTH_USER'])) {
     header("WWW-authenticate: Basic realm=\"" . $_SERVER['REQUEST_URI'] . "\"");

trunk/LayoutTests/http/tests/loading/resources/protected-resource.php

@@ -1 +1 @@
 <?php
 header("Cache-Control: no-store");
+header("Connection: close");
 if (!isset($_SERVER['PHP_AUTH_USER'])) {
     header("WWW-authenticate: Basic realm=\"" . $_SERVER['REQUEST_URI'] . "\"");

trunk/LayoutTests/http/tests/loading/resources/subresources/protected-resource.php

@@ -1 +1 @@
 <?php
 header("Cache-Control: no-store");
+header("Connection: close");
 if (!isset($_SERVER['PHP_AUTH_USER'])) {
     header("WWW-authenticate: Basic realm=\"" . $_SERVER['REQUEST_URI'] . "\"");

trunk/LayoutTests/http/tests/xmlhttprequest/resources/cross-origin-authorization.php

@@ -5 +5 @@
 header("Access-Control-Allow-Origin: http://127.0.0.1:8000");
 header("Access-Control-Allow-Credentials: true");
+header("Connection: close");
 
 if (!isset($_SERVER['PHP_AUTH_USER'])) {

trunk/LayoutTests/http/tests/xmlhttprequest/resources/cross-origin-check-cookies.php

@@ -4 +4 @@
 header("Access-Control-Allow-Origin: http://127.0.0.1:8000");
 header("Access-Control-Allow-Credentials: true");
+header("Connection: close");
 
 $cookie = $_GET['cookie'];

trunk/LayoutTests/http/tests/xmlhttprequest/resources/cross-origin-no-authorization.php

@@ -4 +4 @@
 header("Last-Modified: Thu, 19 Mar 2009 11:22:11 GMT");
 header("Access-Control-Allow-Origin: http://127.0.0.1:8000");
+header("Connection: close");
 
 if (!isset($_SERVER['PHP_AUTH_USER'])) {