Changeset 48572 in webkit


Ignore:
Timestamp:
Sep 20, 2009 7:30:12 PM (15 years ago)
Author:
abarth@webkit.org
Message:

2009-09-20 Adam Barth <​abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Crash when clicking link in unload handler
​https://bugs.webkit.org/show_bug.cgi?id=29525

Test that the first navigation always wins when the page tries to start
a new navigation in an unload handler.

  • fast/loader/resources/fail-and-notify-done.html: Added.
  • fast/loader/resources/pass-and-notify-done.html: Added.
  • fast/loader/unload-form-about-blank-expected.txt: Added.
  • fast/loader/unload-form-about-blank.html: Added.
  • fast/loader/unload-form-expected.txt: Added.
  • fast/loader/unload-form-post-about-blank-expected.txt: Added.
  • fast/loader/unload-form-post-about-blank.html: Added.
  • fast/loader/unload-form-post-expected.txt: Added.
  • fast/loader/unload-form-post.html: Added.
  • fast/loader/unload-form.html: Added.
  • fast/loader/unload-hyperlink-expected.txt: Added.
  • fast/loader/unload-hyperlink.html: Added.
  • fast/loader/unload-javascript-url-expected.txt: Added.
  • fast/loader/unload-javascript-url.html: Added.
  • fast/loader/unload-reload-expected.txt: Added.
  • fast/loader/unload-reload.html: Added.
  • fast/loader/unload-window-location-expected.txt: Added.
  • fast/loader/unload-window-location.html: Added.

2009-09-20 Adam Barth <​abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Crash when clicking link in unload handler
​https://bugs.webkit.org/show_bug.cgi?id=29525

Test that the first navigation always wins when the page tries to start
a new navigation in an unload handler.

Tests: fast/loader/unload-form-about-blank.html

fast/loader/unload-form-post-about-blank.html
fast/loader/unload-form-post.html
fast/loader/unload-form.html
fast/loader/unload-hyperlink.html
fast/loader/unload-javascript-url.html
fast/loader/unload-reload.html
fast/loader/unload-window-location.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURL): (WebCore::FrameLoader::loadWithDocumentLoader):
Location:
trunk
Files:
18 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r48568 r48572  
     12009-09-20  Adam Barth  <abarth@webkit.org>
     2
     3        Reviewed by Maciej Stachowiak.
     4
     5        Crash when clicking link in unload handler
     6        https://bugs.webkit.org/show_bug.cgi?id=29525
     7
     8        Test that the first navigation always wins when the page tries to start
     9        a new navigation in an unload handler.
     10
     11        * fast/loader/resources/fail-and-notify-done.html: Added.
     12        * fast/loader/resources/pass-and-notify-done.html: Added.
     13        * fast/loader/unload-form-about-blank-expected.txt: Added.
     14        * fast/loader/unload-form-about-blank.html: Added.
     15        * fast/loader/unload-form-expected.txt: Added.
     16        * fast/loader/unload-form-post-about-blank-expected.txt: Added.
     17        * fast/loader/unload-form-post-about-blank.html: Added.
     18        * fast/loader/unload-form-post-expected.txt: Added.
     19        * fast/loader/unload-form-post.html: Added.
     20        * fast/loader/unload-form.html: Added.
     21        * fast/loader/unload-hyperlink-expected.txt: Added.
     22        * fast/loader/unload-hyperlink.html: Added.
     23        * fast/loader/unload-javascript-url-expected.txt: Added.
     24        * fast/loader/unload-javascript-url.html: Added.
     25        * fast/loader/unload-reload-expected.txt: Added.
     26        * fast/loader/unload-reload.html: Added.
     27        * fast/loader/unload-window-location-expected.txt: Added.
     28        * fast/loader/unload-window-location.html: Added.
     29
    1302009-09-19  Oliver Hunt  <oliver@apple.com>
    231

  • trunk/WebCore/ChangeLog

    r48571 r48572  
     12009-09-20  Adam Barth  <abarth@webkit.org>
     2
     3        Reviewed by Maciej Stachowiak.
     4
     5        Crash when clicking link in unload handler
     6        https://bugs.webkit.org/show_bug.cgi?id=29525
     7
     8        Test that the first navigation always wins when the page tries to start
     9        a new navigation in an unload handler.
     10
     11        Tests: fast/loader/unload-form-about-blank.html
     12               fast/loader/unload-form-post-about-blank.html
     13               fast/loader/unload-form-post.html
     14               fast/loader/unload-form.html
     15               fast/loader/unload-hyperlink.html
     16               fast/loader/unload-javascript-url.html
     17               fast/loader/unload-reload.html
     18               fast/loader/unload-window-location.html
     19
     20        * loader/FrameLoader.cpp:
     21        (WebCore::FrameLoader::loadURL):
     22        (WebCore::FrameLoader::loadWithDocumentLoader):
     23
    1242009-09-18  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
    225

  • trunk/WebCore/loader/FrameLoader.cpp

    r48545 r48572  
    22922292    PassRefPtr<Event> event, PassRefPtr<FormState> prpFormState)
    22932293{
     2294    if (m_unloadEventBeingDispatched)
     2295        return;
     2296
    22942297    RefPtr<FormState> formState = prpFormState;
    22952298    bool isFormSubmission = formState;
    … …  
    24342437
    24352438    ASSERT(m_frame->view());
     2439
     2440    if (m_unloadEventBeingDispatched)
     2441        return;
    24362442
    24372443    m_policyLoadType = type;
Note: See TracChangeset for help on using the changeset viewer.