Changeset 48810 in webkit

Timestamp:

Sep 28, 2009 6:35:39 AM (15 years ago)

Author:

eric@webkit.org

Message:

2009-09-28 Charles Wei <​charles.wei@torchmobile.com.cn>

Reviewed by Nikolas Zimmermann.

Fix the crash of SVG that crashes when use a non-exist symbol
​https://bugs.webkit.org/show_bug.cgi?id=27693

• svg/custom/use-non-existing-symbol-crash-expected.txt: Added.
• svg/custom/use-non-existing-symbol-crash.svg: Added.

2009-09-28 Charles Wei <​charles.wei@torchmobile.com.cn>

Reviewed by Nikolas Zimmermann.

Fix the crash of SVG that crashes when use a non-exist symbol
​https://bugs.webkit.org/show_bug.cgi?id=27693

Test: svg/custom/use-non-existing-symbol-crash.svg

• svg/SVGUseElement.cpp: (WebCore::shadowTreeContainsChangedNodes):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/svg/custom/use-non-existing-symbol-crash-expected.txt (added)
• LayoutTests/svg/custom/use-non-existing-symbol-crash.svg (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/svg/SVGUseElement.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2009-09-28  Charles Wei  <charles.wei@torchmobile.com.cn>
+
+        Reviewed by Nikolas Zimmermann.
+
+        Fix the crash of SVG that crashes when use a non-exist symbol
+        https://bugs.webkit.org/show_bug.cgi?id=27693
+
+        * svg/custom/use-non-existing-symbol-crash-expected.txt: Added.
+        * svg/custom/use-non-existing-symbol-crash.svg: Added.
+
 2009-09-27  Sam Weinig  <sam@webkit.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-09-28  Charles Wei  <charles.wei@torchmobile.com.cn>
+
+        Reviewed by Nikolas Zimmermann.
+
+        Fix the crash of SVG that crashes when use a non-exist symbol
+        https://bugs.webkit.org/show_bug.cgi?id=27693
+
+        Test: svg/custom/use-non-existing-symbol-crash.svg
+
+        * svg/SVGUseElement.cpp:
+        (WebCore::shadowTreeContainsChangedNodes):
+
 2009-09-28  Joseph Pecoraro  <joepeck@webkit.org>
 

trunk/WebCore/svg/SVGUseElement.cpp

@@ -2 +2 @@
     Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann <zimmermann@kde.org>
                   2004, 2005, 2006, 2007 Rob Buis <buis@kde.org>
+    Copyright (C) Research In Motion Limited 2009, All rights reserved. Charles Wei <charles.wei@torchmobile.com.cn>
 
     This file is part of the KDE project
@@ -159 +160 @@
 static bool shadowTreeContainsChangedNodes(SVGElementInstance* target)
 {
+    if (!target)      // when use is referencing an non-existing element, there will be no Instance tree built
+        return false;
+
     if (target->needsUpdate())
         return true;