Changeset 48828 in webkit


Ignore:
Timestamp:
Sep 28, 2009 1:33:41 PM (15 years ago)
Author:
pfeldman@chromium.org
Message:

2009-09-28 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Add explicit frontend event for commit load.

https://bugs.webkit.org/show_bug.cgi?id=29814

  • inspector/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad):
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didCommitLoad):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent.prototype._setDocument):
  • inspector/front-end/inspector.js: (WebInspector.addResource): (WebInspector.didCommitLoad):
Location:
trunk/WebCore
Files:
6 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r48827 r48828  
     12009-09-28  Pavel Feldman  <pfeldman@chromium.org>
     2
     3        Reviewed by Timothy Hatcher.
     4
     5        Web Inspector: Add explicit frontend event for commit load.
     6
     7        https://bugs.webkit.org/show_bug.cgi?id=29814
     8
     9        * inspector/InspectorController.cpp:
     10        (WebCore::InspectorController::didCommitLoad):
     11        * inspector/InspectorFrontend.cpp:
     12        (WebCore::InspectorFrontend::didCommitLoad):
     13        * inspector/InspectorFrontend.h:
     14        * inspector/front-end/DOMAgent.js:
     15        (WebInspector.DOMAgent.prototype._setDocument):
     16        * inspector/front-end/inspector.js:
     17        (WebInspector.addResource):
     18        (WebInspector.didCommitLoad):
     19
    1202009-09-28  Yaar Schnitman  <yaar@chromium.org>
    221
  • trunk/WebCore/inspector/InspectorController.cpp

    r48799 r48828  
    765765                m_mainResource = 0;
    766766            }
    767             if (windowVisible())
     767            if (windowVisible()) {
     768                m_frontend->didCommitLoad();
    768769                m_domAgent->setDocument(m_inspectedPage->mainFrame()->document());
     770            }
    769771        }
    770772    }
  • trunk/WebCore/inspector/InspectorFrontend.cpp

    r48809 r48828  
    7474}
    7575
     76void InspectorFrontend::didCommitLoad()
     77{
     78    callSimpleFunction("didCommitLoad");
     79}
     80
    7681void InspectorFrontend::addMessageToConsole(const ScriptObject& messageObj, const Vector<ScriptString>& frames, const Vector<ScriptValue> wrappedArguments, const String& message)
    7782{
  • trunk/WebCore/inspector/InspectorFrontend.h

    r48809 r48828  
    6363        ScriptObject newScriptObject();
    6464
     65        void didCommitLoad();
    6566        void addMessageToConsole(const ScriptObject& messageObj, const Vector<ScriptString>& frames, const Vector<ScriptValue> wrappedArguments, const String& message);
    6667        void clearConsoleMessages();
  • trunk/WebCore/inspector/front-end/DOMAgent.js

    r48809 r48828  
    379379    _setDocument: function(payload)
    380380    {
    381         this.document = new WebInspector.DOMDocument(this, this._window, payload);
    382381        this._idToDOMNode = {};
    383         this._idToDOMNode[payload.id] = this.document;
    384         this._bindNodes(this.document.children);
     382        if (payload) {
     383            this.document = new WebInspector.DOMDocument(this, this._window, payload);
     384            this._idToDOMNode[payload.id] = this.document;
     385            this._bindNodes(this.document.children);
     386        } else
     387            this.document = null;
    385388        WebInspector.panels.elements.reset();
    386389    },
    387    
     390
    388391    _setDetachedRoot: function(payload)
    389392    {
  • trunk/WebCore/inspector/front-end/inspector.js

    r48809 r48828  
    920920    this.resourceURLMap[resource.url] = resource;
    921921
    922     if (resource.mainResource) {
     922    if (resource.mainResource)
    923923        this.mainResource = resource;
    924         this.panels.elements.reset();
    925     }
    926924
    927925    if (this.panels.resources)
     
    11211119    delete this.resourceURLMap[oldURL];
    11221120    this.resourceURLMap[resource.url] = resource;
     1121}
     1122
     1123WebInspector.didCommitLoad = function()
     1124{
     1125    // Cleanup elements panel early on inspected page refresh.
     1126    WebInspector.setDocument(null);
    11231127}
    11241128
Note: See TracChangeset for help on using the changeset viewer.