Changeset 48833 in webkit


Ignore:
Timestamp:
Sep 28, 2009 2:22:50 PM (15 years ago)
Author:
eric@webkit.org
Message:

2009-09-25 Eric Seidel <eric@webkit.org>

Reviewed by Simon Fraser.

REGRESSION: media/video-pause-empty-events.html is occasionally timing out on bots
https://bugs.webkit.org/show_bug.cgi?id=28624

No longer skip media tests now that we're disabling hardware compositing instead.
Add leopard-specific results for 2 tests expected to fail with HW compositing disabled.

  • platform/mac-leopard/Skipped:
  • platform/mac-leopard/fast/media/mq-transform-02-expected.checksum: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-02-expected.checksum.
  • platform/mac-leopard/fast/media/mq-transform-02-expected.png: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-02-expected.png.
  • platform/mac-leopard/fast/media/mq-transform-02-expected.txt: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-02-expected.txt.
  • platform/mac-leopard/fast/media/mq-transform-03-expected.checksum: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-03-expected.checksum.
  • platform/mac-leopard/fast/media/mq-transform-03-expected.png: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-03-expected.png.
  • platform/mac-leopard/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-03-expected.txt.

2009-09-27 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Darin Adler.

run-webkit-tests: Do not strip the metrics when there is no expected result for a test.
https://bugs.webkit.org/show_bug.cgi?id=29771

  • Scripts/run-webkit-tests:
Location:
trunk
Files:
6 added
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r48823 r48833  
     12009-09-25  Eric Seidel  <eric@webkit.org>
     2
     3        Reviewed by Simon Fraser.
     4
     5        REGRESSION: media/video-pause-empty-events.html is occasionally timing out on bots
     6        https://bugs.webkit.org/show_bug.cgi?id=28624
     7
     8        No longer skip media tests now that we're disabling hardware compositing instead.
     9        Add leopard-specific results for 2 tests expected to fail with HW compositing disabled.
     10
     11        * platform/mac-leopard/Skipped:
     12        * platform/mac-leopard/fast/media/mq-transform-02-expected.checksum: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-02-expected.checksum.
     13        * platform/mac-leopard/fast/media/mq-transform-02-expected.png: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-02-expected.png.
     14        * platform/mac-leopard/fast/media/mq-transform-02-expected.txt: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-02-expected.txt.
     15        * platform/mac-leopard/fast/media/mq-transform-03-expected.checksum: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-03-expected.checksum.
     16        * platform/mac-leopard/fast/media/mq-transform-03-expected.png: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-03-expected.png.
     17        * platform/mac-leopard/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-03-expected.txt.
     18
    1192009-09-28  Shinichiro Hamaji  <hamaji@chromium.org>
    220
  • trunk/LayoutTests/platform/mac-leopard/Skipped

    r48654 r48833  
    1515platform/mac/fast/text/myanmar-shaping.html
    1616platform/mac/fast/text/thai-combining-mark-positioning.html
    17 
    18 # Intermittent crashes/hangs caused by <rdar://problem/7228836>
    19 # https://bugs.webkit.org/show_bug.cgi?id=28845
    20 media/controls-after-reload.html
    21 media/video-size-intrinsic-scale.html
  • trunk/WebKitTools/ChangeLog

    r48803 r48833  
    115115
    116116        * Scripts/modules/committers.py:
     117
     1182009-09-25  Eric Seidel  <eric@webkit.org>
     119
     120        Reviewed by Simon Fraser.
     121
     122        REGRESSION: media/video-pause-empty-events.html is occasionally timing out on bots
     123        https://bugs.webkit.org/show_bug.cgi?id=28624
     124
     125        Disable hardware compositing on Leopard for versions of QuickTime 7.6.4 and older.
     126
     127        * DumpRenderTree/mac/DumpRenderTree.mm:
     128        (resetDefaultsToConsistentValues):
    117129
    1181302009-09-25  Eric Seidel  <eric@webkit.org>
  • trunk/WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm

    r48745 r48833  
    426426    [preferences setUsesPageCache:NO];
    427427
     428#if defined(BUILDING_ON_LEOPARD)
     429    // Disable hardware composititing to avoid timeouts and crashes from buggy CoreVideo teardown code.
     430    // https://bugs.webkit.org/show_bug.cgi?id=28845 and rdar://problem/7228836
     431    SInt32 qtVersion;
     432    OSErr err = Gestalt(gestaltQuickTimeVersion, &qtVersion);
     433    assert(err == noErr);
     434    // Bug 7228836 exists in at least 7.6.3 and 7.6.4, hopefully it will be fixed in 7.6.5.
     435    // FIXME: Once we know the exact versions of QuickTime affected, we can update this check.
     436    if (qtVersion <= 0x07640000)
     437        [preferences setAcceleratedCompositingEnabled:NO];
     438    else
     439#endif
     440        [preferences setAcceleratedCompositingEnabled:YES];
     441
    428442    [[NSHTTPCookieStorage sharedHTTPCookieStorage] setCookieAcceptPolicy:NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain];
    429443}
Note: See TracChangeset for help on using the changeset viewer.