Changeset 48888 in webkit


Ignore:
Timestamp:
Sep 29, 2009 11:40:51 AM (15 years ago)
Author:
oliver@apple.com
Message:

[GTK] REGRESSION: BitmapImage::getGdkPixbuf fails for non-square images
https://bugs.webkit.org/show_bug.cgi?id=29654

Patch by Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Eric Seidel

Added an additional manual-test for this issue to the existing Gtk
cursor image test.

Location:
trunk/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r48887 r48888  
     12009-09-22  Martin Robinson  <martin.james.robinson@gmail.com>
     2
     3        Reviewed by Eric Seidel.
     4
     5        Fix corruption for non-square images.
     6
     7        [GTK] REGRESSION: BitmapImage::getGdkPixbuf fails for non-square images
     8        https://bugs.webkit.org/show_bug.cgi?id=29654
     9
     10        Added an additional manual-test for this issue to the existing Gtk
     11        cursor image test.
     12
     13        * manual-tests/gtk/cursor-image.html:
     14        * manual-tests/gtk/resources/long_cell.cur: Added.
     15        * platform/graphics/gtk/ImageGtk.cpp:
     16        (WebCore::BitmapImage::getGdkPixbuf):
     17
    1182009-09-29  Alexey Proskuryakov  <ap@apple.com>
    219
  • trunk/WebCore/manual-tests/gtk/cursor-image.html

    r47712 r48888  
    1 <div>Mouse over the grey blocks to change the cursor to a small cross.</div>
     1<div>Mouse over the grey block below to change the cursor to a small cross.</div>
    22<div style="width: 100px; height: 100px; background: lightblue; cursor:url(resources/cell.cur), default;">&nbsp;</div>
     3<div>Mouse over the grey block below to change the cursor to three small crosses.</div>
     4<div style="width: 100px; height: 100px; background: lightblue; cursor:url(resources/long_cell.cur), default;">&nbsp;</div>
  • trunk/WebCore/platform/graphics/gtk/ImageGtk.cpp

    r47689 r48888  
    129129     */
    130130    for (int y = 0; y < height; y++) {
    131         for (int x = 0; x < height; x++) {
     131        for (int x = 0; x < width; x++) {
    132132            unsigned char* source = getCairoSurfacePixel(surfaceData, x, y, surfaceRowStride);
    133133            guchar* dest = getGdkPixbufPixel(pixbufData, x, y, pixbufRowStride);
Note: See TracChangeset for help on using the changeset viewer.