Changeset 48907 in webkit

Timestamp:

Sep 29, 2009 3:10:06 PM (15 years ago)

Author:

pfeldman@chromium.org

Message:

2009-09-29 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Oliver Hunt.

Web Inspector REGRESSION(r47820-r47822): Profiles aren't
added to the inspector unless the inspector is already open
when the profile completes.

​https://bugs.webkit.org/show_bug.cgi?id=29897

• inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._populateProfiles):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/ProfilesPanel.js (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-09-29  Pavel Feldman  <pfeldman@chromium.org>
+
+        Reviewed by Oliver Hunt.
+
+        Web Inspector REGRESSION(r47820-r47822): Profiles aren't
+        added to the inspector unless the inspector is already open
+        when the profile completes.
+
+        https://bugs.webkit.org/show_bug.cgi?id=29897
+
+        * inspector/front-end/ProfilesPanel.js:
+        (WebInspector.ProfilesPanel.prototype._populateProfiles):
+
 2009-09-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 

trunk/WebCore/inspector/front-end/ProfilesPanel.js

@@ -396 +396 @@
     _populateProfiles: function()
     {
-        if (this.sidebarTree.children.length)
+        // FIXME: This code needs to be adjusted when more profiling types are added.
+        // Currently defaults to CPU profiles.
+        var cpuProfiles = this.sidebarTree.children[0];
+        if (cpuProfiles.children.length)
             return;
 
@@ -406 +409 @@
         }
 
-        if (this.sidebarTree.children[0])
-            this.sidebarTree.children[0].select();
+        if (cpuProfiles.children[0])
+            cpuProfiles.children[0].select();
 
         delete this._shouldPopulateProfiles;