Changeset 48965 in webkit

Timestamp:

Oct 1, 2009 3:35:53 AM (15 years ago)

Author:

eric@webkit.org

Message:

2009-10-01 Jakub Wieczorek <​faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
fast/events/open-window-from-another-frame.html from the Skipped list.

​https://bugs.webkit.org/show_bug.cgi?id=29930

• platform/qt/Skipped:

2009-10-01 Jakub Wieczorek <​faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
fast/events/open-window-from-another-frame.html from the Skipped list.

​https://bugs.webkit.org/show_bug.cgi?id=29930

• DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::setPopupBlockingEnabled):
• DumpRenderTree/qt/jsobjects.h:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/qt/Skipped (modified) (1 diff)
• WebKitTools/ChangeLog (modified) (1 diff)
• WebKitTools/DumpRenderTree/qt/jsobjects.cpp (modified) (1 diff)
• WebKitTools/DumpRenderTree/qt/jsobjects.h (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
+
+        Reviewed by Simon Hausmann.
+
+        [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
+        fast/events/open-window-from-another-frame.html from the Skipped list.
+
+        https://bugs.webkit.org/show_bug.cgi?id=29930
+
+        * platform/qt/Skipped:
+
 2009-10-01  Martin Robinson  <martin.james.robinson@gmail.com>
 

trunk/LayoutTests/platform/qt/Skipped

@@ -1026 +1026 @@
 fast/events/onchange-textfield.html
 fast/events/onsearch-enter.html
-fast/events/open-window-from-another-frame.html
 fast/forms/enter-clicks-buttons.html
 fast/forms/input-align-image.html

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
+
+        Reviewed by Simon Hausmann.
+
+        [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
+        fast/events/open-window-from-another-frame.html from the Skipped list.
+
+        https://bugs.webkit.org/show_bug.cgi?id=29930
+
+        * DumpRenderTree/qt/jsobjects.cpp:
+        (LayoutTestController::setPopupBlockingEnabled):
+        * DumpRenderTree/qt/jsobjects.h:
+
 2009-09-30  Cameron McCormack  <cam@mcc.id.au>
 

trunk/WebKitTools/DumpRenderTree/qt/jsobjects.cpp

@@ -292 +292 @@
 }
 
+void LayoutTestController::setPopupBlockingEnabled(bool enable)
+{
+    QWebSettings::globalSettings()->setAttribute(QWebSettings::JavascriptCanOpenWindows, !enable);
+}
+
 bool LayoutTestController::pauseAnimationAtTimeOnElementWithId(const QString &animationName,
                                                                double time,

trunk/WebKitTools/DumpRenderTree/qt/jsobjects.h

@@ -95 +95 @@
     void setFixedContentsSize(int width, int height);
     void setPrivateBrowsingEnabled(bool enable);
+    void setPopupBlockingEnabled(bool enable);
 
     bool pauseAnimationAtTimeOnElementWithId(const QString &animationName, double time, const QString &elementId);