Changeset 49021 in webkit

Timestamp:

Oct 2, 2009 4:32:40 AM (15 years ago)

Author:

eric@webkit.org

Message:

2009-10-02 Philippe Normand <​pnormand@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] missing support for anamorphic PAR video size
​https://bugs.webkit.org/show_bug.cgi?id=29717

cleanup of caps handling in the video sink

• platform/graphics/gtk/VideoSinkGStreamer.cpp: (webkit_video_sink_set_caps):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/gtk/VideoSinkGStreamer.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-10-02  Philippe Normand  <pnormand@igalia.com>
+
+        Reviewed by Gustavo Noronha.
+
+        [GTK] missing support for anamorphic PAR video size
+        https://bugs.webkit.org/show_bug.cgi?id=29717
+
+        cleanup of caps handling in the video sink
+
+        * platform/graphics/gtk/VideoSinkGStreamer.cpp:
+        (webkit_video_sink_set_caps):
+
 2009-10-02  Prasanth Ullattil  <prasanth.ullattil@nokia.com>
 

trunk/WebCore/platform/graphics/gtk/VideoSinkGStreamer.cpp

@@ -180 +180 @@
     GstStructure* structure;
     gboolean ret;
-    const GValue* fps;
-    const GValue* par;
-    gint width, height;
+    gint width, height, fps_n, fps_d;
     int red_mask;
 
@@ -196 +194 @@
     ret = gst_structure_get_int(structure, "width", &width);
     ret &= gst_structure_get_int(structure, "height", &height);
-    fps = gst_structure_get_value(structure, "framerate");
-    ret &= (fps != 0);
-
-    par = gst_structure_get_value(structure, "pixel-aspect-ratio");
-
-    if (!ret)
-        return FALSE;
+
+    /* We dont yet use fps but handy to have */
+    ret &= gst_structure_get_fraction(structure, "framerate",
+                                      &fps_n, &fps_d);
+    g_return_val_if_fail(ret, FALSE);
 
     priv->width = width;
     priv->height = height;
-
-    /* We dont yet use fps or pixel aspect into but handy to have */
-    priv->fps_n = gst_value_get_fraction_numerator(fps);
-    priv->fps_d = gst_value_get_fraction_denominator(fps);
-
-    if (par) {
-        priv->par_n = gst_value_get_fraction_numerator(par);
-        priv->par_d = gst_value_get_fraction_denominator(par);
-    } else
+    priv->fps_n = fps_n;
+    priv->fps_d = fps_d;
+
+    if (!gst_structure_get_fraction(structure, "pixel-aspect-ratio",
+                                    &priv->par_n, &priv->par_d))
         priv->par_n = priv->par_d = 1;