Changeset 49386 in webkit

Timestamp:

Oct 9, 2009 4:32:57 AM (15 years ago)

Author:

eric@webkit.org

Message:

2009-10-09 Girish Ramakrishnan <Girish Ramakrishnan>

Reviewed by Simon Hausmann.

[Qt] Windowless Plugins : Create Pixmap only when size changes.

​https://bugs.webkit.org/show_bug.cgi?id=30214

• plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::updatePluginWidget):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• plugins/qt/PluginViewQt.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-10-09  Girish Ramakrishnan  <girish@forwardbias.in>
+
+        Reviewed by Simon Hausmann.
+
+        [Qt] Windowless Plugins : Create Pixmap only when size changes.
+
+        https://bugs.webkit.org/show_bug.cgi?id=30214
+
+        * plugins/qt/PluginViewQt.cpp:
+        (WebCore::PluginView::updatePluginWidget):
+
 2009-10-08  Jon Honeycutt  <jhoneycutt@apple.com>
 

trunk/WebCore/plugins/qt/PluginViewQt.cpp

@@ -108 +108 @@
         return;
 
-    if (m_drawable)
-        XFreePixmap(QX11Info::display(), m_drawable);
-
-    if (!m_isWindowed) {
+    if (!m_isWindowed && m_windowRect.size() != oldWindowRect.size()) {
+        if (m_drawable)
+            XFreePixmap(QX11Info::display(), m_drawable);
+
         m_drawable = XCreatePixmap(QX11Info::display(), QX11Info::appRootWindow(), m_windowRect.width(), m_windowRect.height(), 
                                    ((NPSetWindowCallbackStruct*)m_npWindow.ws_info)->depth);